[PATCH] rcu: Fix remaining rcu_momentary_dyntick_idle() references

Srikar Dronamraju posted 1 patch 2 months ago
tools/gpio/gpio-sloppy-logic-analyzer.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] rcu: Fix remaining rcu_momentary_dyntick_idle() references
Posted by Srikar Dronamraju 2 months ago
There is one last reference to rcu_momentary_dyntick_idle() after
Commit 32a9f26e5e26 ("rcu: Rename rcu_momentary_dyntick_idle() into rcu_momentary_eqs()")

Rename the same so that we are uniform.

Fixes: 32a9f26e5e26 ("rcu: Rename rcu_momentary_dyntick_idle() into rcu_momentary_eqs()")
Cc: Valentin Schneider <vschneid@redhat.com>
CC: Frederic Weisbecker <frederic@kernel.org>
Cc: Neeraj Upadhyay <neeraj.upadhyay@kernel.org>
Signed-off-by: Srikar Dronamraju <srikar@linux.ibm.com>
---
 tools/gpio/gpio-sloppy-logic-analyzer.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/gpio/gpio-sloppy-logic-analyzer.sh b/tools/gpio/gpio-sloppy-logic-analyzer.sh
index ed21a110df5e..3ef2278e49f9 100755
--- a/tools/gpio/gpio-sloppy-logic-analyzer.sh
+++ b/tools/gpio/gpio-sloppy-logic-analyzer.sh
@@ -113,7 +113,7 @@ init_cpu()
 		taskset -p "$newmask" "$p" || continue
 	done 2>/dev/null >/dev/null
 
-	# Big hammer! Working with 'rcu_momentary_dyntick_idle()' for a more fine-grained solution
+	# Big hammer! Working with 'rcu_momentary_eqs()' for a more fine-grained solution
 	# still printed warnings. Same for re-enabling the stall detector after sampling.
 	echo 1 > /sys/module/rcupdate/parameters/rcu_cpu_stall_suppress
 
-- 
2.35.3
Re: [PATCH] rcu: Fix remaining rcu_momentary_dyntick_idle() references
Posted by Bartosz Golaszewski 1 month, 1 week ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 25 Sep 2024 11:16:18 +0530, Srikar Dronamraju wrote:
> There is one last reference to rcu_momentary_dyntick_idle() after
> Commit 32a9f26e5e26 ("rcu: Rename rcu_momentary_dyntick_idle() into rcu_momentary_eqs()")
> 
> Rename the same so that we are uniform.
> 
> 

I applied it but changed the subject as it targets the GPIO tree and not
RCU.

[1/1] rcu: Fix remaining rcu_momentary_dyntick_idle() references
      commit: a0b6594e411dcae0cc563f5157cf062e93603388

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Re: [PATCH] rcu: Fix remaining rcu_momentary_dyntick_idle() references
Posted by Frederic Weisbecker 1 month, 1 week ago
Le Wed, Sep 25, 2024 at 11:16:18AM +0530, Srikar Dronamraju a écrit :
> There is one last reference to rcu_momentary_dyntick_idle() after
> Commit 32a9f26e5e26 ("rcu: Rename rcu_momentary_dyntick_idle() into rcu_momentary_eqs()")
> 
> Rename the same so that we are uniform.
> 
> Fixes: 32a9f26e5e26 ("rcu: Rename rcu_momentary_dyntick_idle() into rcu_momentary_eqs()")
> Cc: Valentin Schneider <vschneid@redhat.com>
> CC: Frederic Weisbecker <frederic@kernel.org>
> Cc: Neeraj Upadhyay <neeraj.upadhyay@kernel.org>
> Signed-off-by: Srikar Dronamraju <srikar@linux.ibm.com>

Thanks!

I suspect this should be better routed through the GPIO UAPI maintainers?

In which case:

Acked-by: Frederic Weisbecker <frederic@kernel.org>