[PATCH 0/7 v3] Make wake_up_{bit,var} less fragile

NeilBrown posted 7 patches 2 months ago
[PATCH 0/7 v3] Make wake_up_{bit,var} less fragile
Posted by NeilBrown 2 months ago
Hi,

 this is a revised set of patches for cleaning up wake_up_bit and
 wake_up_var and related.  They are the result of more proof reading,
 and of trying to make use of the new interfaces anywhere in the kernel
 where these interfaces are used.

 This should apply after -rc1, or at least after the block tree is merged.

 Note that on current master these cause a build error in bcachefs as it
 hasn't been updated with the new i_state bit management.

 Apart from proof-reading fixes this series enhances the previous series:

 - adds wait_var_event_any_lock() which can be used with any lock for
   which there are foo_lock and foo_unlock functions.  This is useful to
   deal with places that want to call filemap_invalidate_unlock/lock
   while waiting for a var

 - removes might_sleep() for wait_var_event_spinlock() as the code won't
   sleep until after it take the lock

 - adds wait_var_event_io() for io_schedule waits - xfs can use this.

 - as a bonus, softirq gets some improvements to waiting.  Feel free to
   drop or delay that one if not completely comfortable.

Thanks,
NeilBrown
Re: [PATCH 0/7 v3] Make wake_up_{bit,var} less fragile
Posted by Thomas Gleixner 2 months ago
On Wed, Sep 25 2024 at 15:31, NeilBrown wrote:
>  this is a revised set of patches for cleaning up wake_up_bit and
>  wake_up_var and related.  They are the result of more proof reading,
>  and of trying to make use of the new interfaces anywhere in the kernel
>  where these interfaces are used.

Now I have two variants of a v3 patch set in my inbox. One with 7 and
one with 8 patches. Both sent within a couple of minutes....

Confused.

Thanks,

        tglx
Re: [PATCH 0/7 v3] Make wake_up_{bit,var} less fragile
Posted by NeilBrown 2 months ago
On Fri, 27 Sep 2024, Thomas Gleixner wrote:
> On Wed, Sep 25 2024 at 15:31, NeilBrown wrote:
> >  this is a revised set of patches for cleaning up wake_up_bit and
> >  wake_up_var and related.  They are the result of more proof reading,
> >  and of trying to make use of the new interfaces anywhere in the kernel
> >  where these interfaces are used.
> 
> Now I have two variants of a v3 patch set in my inbox. One with 7 and
> one with 8 patches. Both sent within a couple of minutes....
> 
> Confused.

Arg - sorry about that.  I realise now what went wrong.

Please use the one with 7 patches.  The first patch in the set of 8 has
already been accepted by Jens for the block tree and has now been merged
(as of Wednesday afternoon).

Thanks,
NeilBrown