bpftool: Remove llvm-strip from Makefile

[PATCH bpf-next] bpftool: Remove llvm-strip from Makefile

Posted by Tao Chen 2 months ago

As Quentin and Andrri said [0], bpftool gen object strips
out DWARF already, so remove the repeat operation.

[0] https://github.com/libbpf/bpftool/issues/161

Suggested-by: Andrii Nakryiko <andrii@kernel.org>
Suggested-by: Quentin Monnet <qmo@kernel.org>
Signed-off-by: Tao Chen <chen.dylane@gmail.com>
---
 tools/bpf/bpftool/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
index ba927379eb20..43bd826b0879 100644
--- a/tools/bpf/bpftool/Makefile
+++ b/tools/bpf/bpftool/Makefile
@@ -219,7 +219,6 @@ $(OUTPUT)%.bpf.o: skeleton/%.bpf.c $(OUTPUT)vmlinux.h $(LIBBPF_BOOTSTRAP)
 		-I$(LIBBPF_BOOTSTRAP_INCLUDE) \
 		-g -O2 -Wall -fno-stack-protector \
 		--target=bpf -c $< -o $@
-	$(Q)$(LLVM_STRIP) -g $@
 
 $(OUTPUT)%.skel.h: $(OUTPUT)%.bpf.o $(BPFTOOL_BOOTSTRAP)
 	$(QUIET_GEN)$(BPFTOOL_BOOTSTRAP) gen skeleton $< > $@
-- 
2.25.1

Re: [PATCH bpf-next] bpftool: Remove llvm-strip from Makefile

Posted by Quentin Monnet 2 months ago

2024-09-25 00:52 UTC+0800 ~ Tao Chen <chen.dylane@gmail.com>
> As Quentin and Andrri said [0], bpftool gen object strips
> out DWARF already, so remove the repeat operation.
> 
> [0] https://github.com/libbpf/bpftool/issues/161
> 
> Suggested-by: Andrii Nakryiko <andrii@kernel.org>
> Suggested-by: Quentin Monnet <qmo@kernel.org>
> Signed-off-by: Tao Chen <chen.dylane@gmail.com>

Acked-by: Quentin Monnet <qmo@kernel.org>

Thank you!