[PATCH] selftests/bpf: Add missing va_end.

zhangjiao2 posted 1 patch 2 months ago
tools/testing/selftests/bpf/test_progs.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] selftests/bpf: Add missing va_end.
Posted by zhangjiao2 2 months ago
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>

There is no va_end after va_copy, just add it.

Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
 tools/testing/selftests/bpf/test_progs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
index c7a70e1a1085..7846f7f98908 100644
--- a/tools/testing/selftests/bpf/test_progs.c
+++ b/tools/testing/selftests/bpf/test_progs.c
@@ -868,6 +868,7 @@ static int libbpf_print_fn(enum libbpf_print_level level,
 
 		va_copy(args2, args);
 		vfprintf(libbpf_capture_stream, format, args2);
+		va_end(args2);
 	}
 
 	if (env.verbosity < VERBOSE_VERY && level == LIBBPF_DEBUG)
-- 
2.33.0
Re: [PATCH] selftests/bpf: Add missing va_end.
Posted by Eduard Zingerman 2 months ago
On Tue, 2024-09-24 at 12:55 +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> There is no va_end after va_copy, just add it.
> 
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---

My bad, thank you for fixing this.

Acked-by: Eduard Zingerman <eddyz87@gmail.com>