[RESEND PATCH] bcachefs: Remove duplicate included headers

Thorsten Blum posted 1 patch 2 months ago
fs/bcachefs/bcachefs_format.h | 2 --
1 file changed, 2 deletions(-)
[RESEND PATCH] bcachefs: Remove duplicate included headers
Posted by Thorsten Blum 2 months ago
From: Thorsten Blum <thorsten.blum@toblux.com>

The header files dirent_format.h and disk_groups_format.h are included
twice. Remove the redundant includes and the following warnings reported
by make includecheck:

  disk_groups_format.h is included more than once
  dirent_format.h is included more than once

Reviewed-by: Hongbo Li <lihongbo22@huawei.com>
Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 fs/bcachefs/bcachefs_format.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/bcachefs/bcachefs_format.h b/fs/bcachefs/bcachefs_format.h
index 14ce726bf5a3..b97fd0f75831 100644
--- a/fs/bcachefs/bcachefs_format.h
+++ b/fs/bcachefs/bcachefs_format.h
@@ -499,8 +499,6 @@ struct bch_sb_field {
 #include "disk_groups_format.h"
 #include "extents_format.h"
 #include "ec_format.h"
-#include "dirent_format.h"
-#include "disk_groups_format.h"
 #include "inode_format.h"
 #include "journal_seq_blacklist_format.h"
 #include "logged_ops_format.h"
-- 
2.46.1
Re: [RESEND PATCH] bcachefs: Remove duplicate included headers
Posted by Kent Overstreet 2 months ago
On Mon, Sep 23, 2024 at 04:20:29PM GMT, Thorsten Blum wrote:
> From: Thorsten Blum <thorsten.blum@toblux.com>
> 
> The header files dirent_format.h and disk_groups_format.h are included
> twice. Remove the redundant includes and the following warnings reported
> by make includecheck:
> 
>   disk_groups_format.h is included more than once
>   dirent_format.h is included more than once
> 
> Reviewed-by: Hongbo Li <lihongbo22@huawei.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>

Applied