Fix data mismatch over ipsec tunnel encrypted/decrypted with ppc64le AES/GCM module.

This patch is to fix an issue when simd is not usable that data mismatch
may occur. The fix is to register algs as SIMD modules so that the
algorithm is excecuted when SIMD instructions is usable.

A new module rfc4106(gcm(aes)) is also added. Re-write AES/GCM assembly
codes with smaller footprints and small performance gain.

This patch has been tested with the kernel crypto module tcrypt.ko and
has passed the selftest.  The patch is also tested with
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled.

Fixes: fd0e9b3e2ee6 ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")
Fixes: cdcecfd9991f ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
Fixes: 45a4672b9a6e2 ("crypto: p10-aes-gcm - Update Kconfig and Makefile")

Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>

Danny Tsen (3):
  crypto: Re-write AES/GCM stitched implementation for ppcle64.
  crypto: Register modules as SIMD modules for ppcle64 AES/GCM algs.
  crypto: added CRYPTO_SIMD in Kconfig for CRYPTO_AES_GCM_P10.

 arch/powerpc/crypto/Kconfig            |    2 +-
 arch/powerpc/crypto/aes-gcm-p10-glue.c |  141 +-
 arch/powerpc/crypto/aes-gcm-p10.S      | 2421 +++++++++++-------------
 3 files changed, 1187 insertions(+), 1377 deletions(-)

-- 
2.43.0

On Mon, Sep 23, 2024 at 09:30:37AM -0400, Danny Tsen wrote:
> Fix data mismatch over ipsec tunnel encrypted/decrypted with ppc64le AES/GCM module.
> 
> This patch is to fix an issue when simd is not usable that data mismatch
> may occur. The fix is to register algs as SIMD modules so that the
> algorithm is excecuted when SIMD instructions is usable.
> 
> A new module rfc4106(gcm(aes)) is also added. Re-write AES/GCM assembly
> codes with smaller footprints and small performance gain.
> 
> This patch has been tested with the kernel crypto module tcrypt.ko and
> has passed the selftest.  The patch is also tested with
> CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled.
> 
> Fixes: fd0e9b3e2ee6 ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")
> Fixes: cdcecfd9991f ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
> Fixes: 45a4672b9a6e2 ("crypto: p10-aes-gcm - Update Kconfig and Makefile")
> 
> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
> 
> Danny Tsen (3):
>   crypto: Re-write AES/GCM stitched implementation for ppcle64.
>   crypto: Register modules as SIMD modules for ppcle64 AES/GCM algs.
>   crypto: added CRYPTO_SIMD in Kconfig for CRYPTO_AES_GCM_P10.
> 
>  arch/powerpc/crypto/Kconfig            |    2 +-
>  arch/powerpc/crypto/aes-gcm-p10-glue.c |  141 +-
>  arch/powerpc/crypto/aes-gcm-p10.S      | 2421 +++++++++++-------------
>  3 files changed, 1187 insertions(+), 1377 deletions(-)
> 
> -- 
> 2.43.0

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Thanks Herbert.

-Danny

On 10/5/24 12:35 AM, Herbert Xu wrote:
> On Mon, Sep 23, 2024 at 09:30:37AM -0400, Danny Tsen wrote:
>> Fix data mismatch over ipsec tunnel encrypted/decrypted with ppc64le AES/GCM module.
>>
>> This patch is to fix an issue when simd is not usable that data mismatch
>> may occur. The fix is to register algs as SIMD modules so that the
>> algorithm is excecuted when SIMD instructions is usable.
>>
>> A new module rfc4106(gcm(aes)) is also added. Re-write AES/GCM assembly
>> codes with smaller footprints and small performance gain.
>>
>> This patch has been tested with the kernel crypto module tcrypt.ko and
>> has passed the selftest.  The patch is also tested with
>> CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled.
>>
>> Fixes: fd0e9b3e2ee6 ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")
>> Fixes: cdcecfd9991f ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
>> Fixes: 45a4672b9a6e2 ("crypto: p10-aes-gcm - Update Kconfig and Makefile")
>>
>> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
>>
>> Danny Tsen (3):
>>    crypto: Re-write AES/GCM stitched implementation for ppcle64.
>>    crypto: Register modules as SIMD modules for ppcle64 AES/GCM algs.
>>    crypto: added CRYPTO_SIMD in Kconfig for CRYPTO_AES_GCM_P10.
>>
>>   arch/powerpc/crypto/Kconfig            |    2 +-
>>   arch/powerpc/crypto/aes-gcm-p10-glue.c |  141 +-
>>   arch/powerpc/crypto/aes-gcm-p10.S      | 2421 +++++++++++-------------
>>   3 files changed, 1187 insertions(+), 1377 deletions(-)
>>
>> -- 
>> 2.43.0
> All applied.  Thanks.