[PATCH] mm/damon: Update DAMON doc URL

Diederik de Haas posted 1 patch 2 months ago
mm/damon/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] mm/damon: Update DAMON doc URL
Posted by Diederik de Haas 2 months ago
The old URL doesn't really work anymore and as the documentation has
been integrated in the main kernel documentation site, change the URL to
point to that.

Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
 mm/damon/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig
index fecb8172410c..35b72f88983a 100644
--- a/mm/damon/Kconfig
+++ b/mm/damon/Kconfig
@@ -9,7 +9,7 @@ config DAMON
 	  access frequency of each memory region. The information can be useful
 	  for performance-centric DRAM level memory management.
 
-	  See https://damonitor.github.io/doc/html/latest-damon/index.html for
+	  See https://www.kernel.org/doc/html/latest/mm/damon/index.html for
 	  more information.
 
 config DAMON_KUNIT_TEST
-- 
2.45.2
Re: [PATCH] mm/damon: Update DAMON doc URL
Posted by SeongJae Park 2 months ago
Hi Diederik,

On Mon, 23 Sep 2024 12:05:58 +0200 Diederik de Haas <didi.debian@cknow.org> wrote:

> The old URL doesn't really work anymore and as the documentation has
> been integrated in the main kernel documentation site, change the URL to
> point to that.

Nice finding!  Thank you for fixing this!

Nonetheless, I'd prefer having 'mm/damon/Kconfig:' as the prefix of the commit
subject.

> 
> Signed-off-by: Diederik de Haas <didi.debian@cknow.org>

Other than the trivial nit,

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

> ---
>  mm/damon/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig
> index fecb8172410c..35b72f88983a 100644
> --- a/mm/damon/Kconfig
> +++ b/mm/damon/Kconfig
> @@ -9,7 +9,7 @@ config DAMON
>  	  access frequency of each memory region. The information can be useful
>  	  for performance-centric DRAM level memory management.
>  
> -	  See https://damonitor.github.io/doc/html/latest-damon/index.html for
> +	  See https://www.kernel.org/doc/html/latest/mm/damon/index.html for
>  	  more information.
>  
>  config DAMON_KUNIT_TEST
> -- 
> 2.45.2
Re: [PATCH] mm/damon: Update DAMON doc URL
Posted by Diederik de Haas 2 months ago
Hi SeongJae,

On Mon Sep 23, 2024 at 6:32 PM CEST, SeongJae Park wrote:
> On Mon, 23 Sep 2024 12:05:58 +0200 Diederik de Haas <didi.debian@cknow.org> wrote:
>
> > The old URL doesn't really work anymore and as the documentation has
> > been integrated in the main kernel documentation site, change the URL to
> > point to that.
>
> Nice finding!  Thank you for fixing this!
>
> Nonetheless, I'd prefer having 'mm/damon/Kconfig:' as the prefix of the commit
> subject.

Do you want me to send a v2 for it or will that be fixed when
committing?

> Other than the trivial nit,
>
> Reviewed-by: SeongJae Park <sj@kernel.org>

Thanks :)

Cheers,
  Diederik

> > ---
> >  mm/damon/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig
> > index fecb8172410c..35b72f88983a 100644
> > --- a/mm/damon/Kconfig
> > +++ b/mm/damon/Kconfig
> > @@ -9,7 +9,7 @@ config DAMON
> >  	  access frequency of each memory region. The information can be useful
> >  	  for performance-centric DRAM level memory management.
> >  
> > -	  See https://damonitor.github.io/doc/html/latest-damon/index.html for
> > +	  See https://www.kernel.org/doc/html/latest/mm/damon/index.html for
> >  	  more information.
> >  
> >  config DAMON_KUNIT_TEST
> > -- 
> > 2.45.2

Re: [PATCH] mm/damon: Update DAMON doc URL
Posted by SeongJae Park 2 months ago
On Mon, 23 Sep 2024 18:46:57 +0200 "Diederik de Haas" <didi.debian@cknow.org> wrote:

> Hi SeongJae,
> 
> On Mon Sep 23, 2024 at 6:32 PM CEST, SeongJae Park wrote:
> > On Mon, 23 Sep 2024 12:05:58 +0200 Diederik de Haas <didi.debian@cknow.org> wrote:
> >
> > > The old URL doesn't really work anymore and as the documentation has
> > > been integrated in the main kernel documentation site, change the URL to
> > > point to that.
> >
> > Nice finding!  Thank you for fixing this!
> >
> > Nonetheless, I'd prefer having 'mm/damon/Kconfig:' as the prefix of the commit
> > subject.
> 
> Do you want me to send a v2 for it or will that be fixed when
> committing?

I think Andrew would make the change on his town when he adds this to mm tree.
But I'd like to reduce his burden if possible.  So, if you don't mind, please
send v2.


Thanks,
SJ

> 
> > Other than the trivial nit,
> >
> > Reviewed-by: SeongJae Park <sj@kernel.org>
> 
> Thanks :)
> 
> Cheers,
>   Diederik
> 
> > > ---
> > >  mm/damon/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig
> > > index fecb8172410c..35b72f88983a 100644
> > > --- a/mm/damon/Kconfig
> > > +++ b/mm/damon/Kconfig
> > > @@ -9,7 +9,7 @@ config DAMON
> > >  	  access frequency of each memory region. The information can be useful
> > >  	  for performance-centric DRAM level memory management.
> > >  
> > > -	  See https://damonitor.github.io/doc/html/latest-damon/index.html for
> > > +	  See https://www.kernel.org/doc/html/latest/mm/damon/index.html for
> > >  	  more information.
> > >  
> > >  config DAMON_KUNIT_TEST
> > > -- 
> > > 2.45.2
> 
>