[PATCH] NFSD: Remove unnecessary posix_acl_entry pointer initialization

Thorsten Blum posted 1 patch 2 months ago
fs/nfsd/nfs4acl.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] NFSD: Remove unnecessary posix_acl_entry pointer initialization
Posted by Thorsten Blum 2 months ago
The posix_acl_entry pointer pe is already initialized by the
FOREACH_ACL_ENTRY() macro. Remove the unnecessary initialization.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 fs/nfsd/nfs4acl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c
index 96e786b5e544..936ea1ad9586 100644
--- a/fs/nfsd/nfs4acl.c
+++ b/fs/nfsd/nfs4acl.c
@@ -198,8 +198,6 @@ summarize_posix_acl(struct posix_acl *acl, struct posix_acl_summary *pas)
 	memset(pas, 0, sizeof(*pas));
 	pas->mask = 07;
 
-	pe = acl->a_entries + acl->a_count;
-
 	FOREACH_ACL_ENTRY(pa, acl, pe) {
 		switch (pa->e_tag) {
 			case ACL_USER_OBJ:
-- 
2.46.1
Re: [PATCH] NFSD: Remove unnecessary posix_acl_entry pointer initialization
Posted by cel@kernel.org 2 months ago
From: Chuck Lever <chuck.lever@oracle.com>

On Mon, 23 Sep 2024 10:05:46 +0200, Thorsten Blum wrote:                                              
> The posix_acl_entry pointer pe is already initialized by the
> FOREACH_ACL_ENTRY() macro. Remove the unnecessary initialization.
> 
>                                                                         

Applied to nfsd-next for v6.13, thanks!                                                                

[1/1] NFSD: Remove unnecessary posix_acl_entry pointer initialization
      commit: 45672c5446544da68e7f46079c7c3c7bebcc1d3d                                                                      

--                                                                              
Chuck Lever