Add missing terminator to list of unit tests to avoid random crashes seen
when running the test.

Fixes: 10ca05a76065 ("ipe: kunit test for parser")
Cc: Deven Bowers <deven.desai@linux.microsoft.com>
Cc: Paul Moore <paul@paul-moore.com>
Cc: Fan Wu <wufan@linux.microsoft.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 security/ipe/policy_tests.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/ipe/policy_tests.c b/security/ipe/policy_tests.c
index 89521f6b9994..5f1654deeb04 100644
--- a/security/ipe/policy_tests.c
+++ b/security/ipe/policy_tests.c
@@ -286,6 +286,7 @@ static void ipe_parser_widestring_test(struct kunit *test)
 static struct kunit_case ipe_parser_test_cases[] = {
 	KUNIT_CASE_PARAM(ipe_parser_unsigned_test, ipe_policies_gen_params),
 	KUNIT_CASE(ipe_parser_widestring_test),
+	{ }
 };
 
 static struct kunit_suite ipe_parser_test_suite = {
-- 
2.45.2

On Sep 22, 2024 Guenter Roeck <linux@roeck-us.net> wrote:
> 
> Add missing terminator to list of unit tests to avoid random crashes seen
> when running the test.
> 
> Fixes: 10ca05a76065 ("ipe: kunit test for parser")
> Cc: Deven Bowers <deven.desai@linux.microsoft.com>
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: Fan Wu <wufan@linux.microsoft.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Acked-by: Fan Wu <wufan@linux.microsoft.com>
> ---
>  security/ipe/policy_tests.c | 1 +
>  1 file changed, 1 insertion(+)

Thanks, merged into lsm/stable-6.12.

--
paul-moore.com

On Sun, Sep 22, 2024 at 10:52 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> Add missing terminator to list of unit tests to avoid random crashes seen
> when running the test.
>
> Fixes: 10ca05a76065 ("ipe: kunit test for parser")
> Cc: Deven Bowers <deven.desai@linux.microsoft.com>
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: Fan Wu <wufan@linux.microsoft.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  security/ipe/policy_tests.c | 1 +
>  1 file changed, 1 insertion(+)

I'm guessing Fan doesn't have his tree setup yet, but if I can get an
ACK from Fan I can send this up via the LSM tree for the next
v6.12-rcX release.

> diff --git a/security/ipe/policy_tests.c b/security/ipe/policy_tests.c
> index 89521f6b9994..5f1654deeb04 100644
> --- a/security/ipe/policy_tests.c
> +++ b/security/ipe/policy_tests.c
> @@ -286,6 +286,7 @@ static void ipe_parser_widestring_test(struct kunit *test)
>  static struct kunit_case ipe_parser_test_cases[] = {
>         KUNIT_CASE_PARAM(ipe_parser_unsigned_test, ipe_policies_gen_params),
>         KUNIT_CASE(ipe_parser_widestring_test),
> +       { }
>  };
>
>  static struct kunit_suite ipe_parser_test_suite = {

-- 
paul-moore.com

On 9/22/2024 5:27 PM, Paul Moore wrote:
> On Sun, Sep 22, 2024 at 10:52 AM Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> Add missing terminator to list of unit tests to avoid random crashes seen
>> when running the test.
>>
>> Fixes: 10ca05a76065 ("ipe: kunit test for parser")
>> Cc: Deven Bowers <deven.desai@linux.microsoft.com>
>> Cc: Paul Moore <paul@paul-moore.com>
>> Cc: Fan Wu <wufan@linux.microsoft.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>>   security/ipe/policy_tests.c | 1 +
>>   1 file changed, 1 insertion(+)
> 
> I'm guessing Fan doesn't have his tree setup yet, but if I can get an
> ACK from Fan I can send this up via the LSM tree for the next
> v6.12-rcX release.
> 
>> diff --git a/security/ipe/policy_tests.c b/security/ipe/policy_tests.c
>> index 89521f6b9994..5f1654deeb04 100644
>> --- a/security/ipe/policy_tests.c
>> +++ b/security/ipe/policy_tests.c
>> @@ -286,6 +286,7 @@ static void ipe_parser_widestring_test(struct kunit *test)
>>   static struct kunit_case ipe_parser_test_cases[] = {
>>          KUNIT_CASE_PARAM(ipe_parser_unsigned_test, ipe_policies_gen_params),
>>          KUNIT_CASE(ipe_parser_widestring_test),
>> +       { }
>>   };
>>
>>   static struct kunit_suite ipe_parser_test_suite = {
> 

Yes this looks good to me.

Acked-by: Fan Wu <wufan@linux.microsoft.com>