[PATCH] regulator: isl6271a: Drop explicit initialization of struct i2c_device_id::driver_data to 0

Uwe Kleine-König posted 1 patch 2 months, 1 week ago
drivers/regulator/isl6271a-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] regulator: isl6271a: Drop explicit initialization of struct i2c_device_id::driver_data to 0
Posted by Uwe Kleine-König 2 months, 1 week ago
These drivers don't use the driver_data member of struct i2c_device_id,
so don't explicitly initialize this member.

This prepares putting driver_data in an anonymous union which requires
either no initialization or named designators. But it's also a nice
cleanup on its own.

While touching the initializer, also remove the comma after the sentinel
entry.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
 drivers/regulator/isl6271a-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/isl6271a-regulator.c b/drivers/regulator/isl6271a-regulator.c
index 69b4afe95e66..7883cd160727 100644
--- a/drivers/regulator/isl6271a-regulator.c
+++ b/drivers/regulator/isl6271a-regulator.c
@@ -138,8 +138,8 @@ static int isl6271a_probe(struct i2c_client *i2c)
 }
 
 static const struct i2c_device_id isl6271a_id[] = {
-	{.name = "isl6271a", 0 },
-	{ },
+	{ .name = "isl6271a", },
+	{ }
 };
 
 MODULE_DEVICE_TABLE(i2c, isl6271a_id);

base-commit: 62f92d634458a1e308bb699986b9147a6d670457
-- 
2.45.2

Re: [PATCH] regulator: isl6271a: Drop explicit initialization of struct i2c_device_id::driver_data to 0
Posted by Mark Brown 1 month, 4 weeks ago
On Fri, 20 Sep 2024 17:34:32 +0200, Uwe Kleine-König wrote:
> These drivers don't use the driver_data member of struct i2c_device_id,
> so don't explicitly initialize this member.
> 
> This prepares putting driver_data in an anonymous union which requires
> either no initialization or named designators. But it's also a nice
> cleanup on its own.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: isl6271a: Drop explicit initialization of struct i2c_device_id::driver_data to 0
      commit: f4e06afb0b47eb8ef6aa42eb8df2adb73b397bf7

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark