wifi: rt2x00: convert comma to semicolon

[PATCH v1] wifi: rt2x00: convert comma to semicolon

Posted by Yan Zhen 1 year, 3 months ago

To ensure code clarity and prevent potential errors, it's advisable
to employ the ';' as a statement separator, except when ',' are
intentionally used for specific purposes.

Signed-off-by: Yan Zhen <yanzhen@vivo.com>
---
 drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
index 3bb81bcff0ac..60c2a12e9d5e 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -3607,7 +3607,7 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev,
 			rt2800_rfcsr_write(rt2x00dev, 52, 0x0C);
 			rt2800_rfcsr_write(rt2x00dev, 54, 0xF8);
 			if (rf->channel <= 50) {
-				rt2800_rfcsr_write(rt2x00dev, 55, 0x06),
+				rt2800_rfcsr_write(rt2x00dev, 55, 0x06);
 				rt2800_rfcsr_write(rt2x00dev, 56, 0xD3);
 			} else if (rf->channel >= 52) {
 				rt2800_rfcsr_write(rt2x00dev, 55, 0x04);
-- 
2.34.1

Re: [PATCH v1] wifi: rt2x00: convert comma to semicolon

Posted by Kalle Valo 1 year, 2 months ago

Yan Zhen <yanzhen@vivo.com> wrote:

> To ensure code clarity and prevent potential errors, it's advisable
> to employ the ';' as a statement separator, except when ',' are
> intentionally used for specific purposes.
> 
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>
> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>

Patch applied to wireless-next.git, thanks.

c8945c8cd41a wifi: rt2x00: convert comma to semicolon

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240920025917.1959932-1-yanzhen@vivo.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH v1] wifi: rt2x00: convert comma to semicolon

Posted by Stanislaw Gruszka 1 year, 3 months ago

On Fri, Sep 20, 2024 at 10:59:17AM +0800, Yan Zhen wrote:
> To ensure code clarity and prevent potential errors, it's advisable
> to employ the ';' as a statement separator, except when ',' are
> intentionally used for specific purposes.
> 
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
> ---
>  drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> index 3bb81bcff0ac..60c2a12e9d5e 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> @@ -3607,7 +3607,7 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev,
>  			rt2800_rfcsr_write(rt2x00dev, 52, 0x0C);
>  			rt2800_rfcsr_write(rt2x00dev, 54, 0xF8);
>  			if (rf->channel <= 50) {
> -				rt2800_rfcsr_write(rt2x00dev, 55, 0x06),
> +				rt2800_rfcsr_write(rt2x00dev, 55, 0x06);
>  				rt2800_rfcsr_write(rt2x00dev, 56, 0xD3);
>  			} else if (rf->channel >= 52) {
>  				rt2800_rfcsr_write(rt2x00dev, 55, 0x04);
> -- 
> 2.34.1
>