[PATCH] nvme: Open brace following function definition on next line

Andreas Kühn posted 1 patch 2 months, 1 week ago
drivers/nvme/host/constants.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] nvme: Open brace following function definition on next line
Posted by Andreas Kühn 2 months, 1 week ago
Open brace following function definition go on the next line. Fix it.

Signed-off-by: Andreas Kühn <andreas.kuehn@diekuehnen.com>
---
 drivers/nvme/host/constants.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/constants.c b/drivers/nvme/host/constants.c
index 2b9e6cfaf2a8..66d6158822c5 100644
--- a/drivers/nvme/host/constants.c
+++ b/drivers/nvme/host/constants.c
@@ -195,7 +195,8 @@ const char *nvme_get_admin_opcode_str(u8 opcode)
 }
 EXPORT_SYMBOL_GPL(nvme_get_admin_opcode_str);
 
-const char *nvme_get_fabrics_opcode_str(u8 opcode) {
+const char *nvme_get_fabrics_opcode_str(u8 opcode)
+{
 	if (opcode < ARRAY_SIZE(nvme_fabrics_ops) && nvme_fabrics_ops[opcode])
 		return nvme_fabrics_ops[opcode];
 	return "Unknown";
-- 
2.43.0

Re: [PATCH] nvme: Open brace following function definition on next line
Posted by Christoph Hellwig 2 months, 1 week ago
On Wed, Sep 18, 2024 at 03:29:35PM +0200, Andreas Kühn wrote:
> Open brace following function definition go on the next line. Fix it.

That's indeed our usual style, but random drive by cleanup aren't
really all that helpful and just create clutter.