drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
To ensure code clarity and prevent potential errors, it's advisable
to employ the ';' as a statement separator, except when ',' are
intentionally used for specific purposes.
Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index cd9ee171e0df..f2dce9896a48 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -1310,8 +1310,8 @@ static int intel_hdmi_hdcp_write(struct intel_digital_port *dig_port,
memcpy(&write_buf[1], buffer, size);
msg.addr = DRM_HDCP_DDC_ADDR;
- msg.flags = 0,
- msg.len = size + 1,
+ msg.flags = 0;
+ msg.len = size + 1;
msg.buf = write_buf;
ret = i2c_transfer(ddc, &msg, 1);
--
2.17.1
On Wed, 18 Sep 2024, Shen Lichuan <shenlichuan@vivo.com> wrote: > To ensure code clarity and prevent potential errors, it's advisable > to employ the ';' as a statement separator, except when ',' are > intentionally used for specific purposes. > > Signed-off-by: Shen Lichuan <shenlichuan@vivo.com> Already fixed by commit 7cd1049a33ca ("drm/i915/hdmi: convert comma to semicolon"). Please use the latest drm-tip branch of [1] when contributing to i915 or xe drivers. BR, Jani. [1] https://gitlab.freedesktop.org/drm/tip > --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > index cd9ee171e0df..f2dce9896a48 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -1310,8 +1310,8 @@ static int intel_hdmi_hdcp_write(struct intel_digital_port *dig_port, > memcpy(&write_buf[1], buffer, size); > > msg.addr = DRM_HDCP_DDC_ADDR; > - msg.flags = 0, > - msg.len = size + 1, > + msg.flags = 0; > + msg.len = size + 1; > msg.buf = write_buf; > > ret = i2c_transfer(ddc, &msg, 1); -- Jani Nikula, Intel
© 2016 - 2024 Red Hat, Inc.