xtensa: annotate dtb_start variable as static __initdata

[PATCH] xtensa: annotate dtb_start variable as static __initdata

Posted by Masahiro Yamada 2 months, 1 week ago

The 'dtb_start' variable is only used within arch/xtensa/kernel/setup.c.
Mark it as 'static'.

It is only used by parse_tag_fdt() and init_arch(), both of which are
annotated as __init. Therefore, dtb_start can be annotated as __initdata,
so it will discarded after boot.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 arch/xtensa/kernel/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/xtensa/kernel/setup.c b/arch/xtensa/kernel/setup.c
index bdec4a773af0..3e076b64cc61 100644
--- a/arch/xtensa/kernel/setup.c
+++ b/arch/xtensa/kernel/setup.c
@@ -55,7 +55,7 @@ extern int initrd_below_start_ok;
 #endif
 
 #ifdef CONFIG_USE_OF
-void *dtb_start = __dtb_start;
+static void *dtb_start __initdata = __dtb_start;
 #endif
 
 extern unsigned long loops_per_jiffy;
-- 
2.43.0

Re: [PATCH] xtensa: annotate dtb_start variable as static __initdata

Posted by Masahiro Yamada 3 weeks, 1 day ago

On Wed, Sep 18, 2024 at 12:15 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> The 'dtb_start' variable is only used within arch/xtensa/kernel/setup.c.
> Mark it as 'static'.
>
> It is only used by parse_tag_fdt() and init_arch(), both of which are
> annotated as __init. Therefore, dtb_start can be annotated as __initdata,
> so it will discarded after boot.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---

Ping?

>
>  arch/xtensa/kernel/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/xtensa/kernel/setup.c b/arch/xtensa/kernel/setup.c
> index bdec4a773af0..3e076b64cc61 100644
> --- a/arch/xtensa/kernel/setup.c
> +++ b/arch/xtensa/kernel/setup.c
> @@ -55,7 +55,7 @@ extern int initrd_below_start_ok;
>  #endif
>
>  #ifdef CONFIG_USE_OF
> -void *dtb_start = __dtb_start;
> +static void *dtb_start __initdata = __dtb_start;
>  #endif
>
>  extern unsigned long loops_per_jiffy;
> --
> 2.43.0
>


-- 
Best Regards
Masahiro Yamada

Re: [PATCH] xtensa: annotate dtb_start variable as static __initdata

Posted by Max Filippov 3 weeks ago

On Wed, Nov 6, 2024 at 8:51 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Wed, Sep 18, 2024 at 12:15 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > The 'dtb_start' variable is only used within arch/xtensa/kernel/setup.c.
> > Mark it as 'static'.
> >
> > It is only used by parse_tag_fdt() and init_arch(), both of which are
> > annotated as __init. Therefore, dtb_start can be annotated as __initdata,
> > so it will discarded after boot.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
>
> Ping?

Thanks. Applied to my xtensa tree.

-- Max