[PATCH -next v2] drm/msm: Remove unneeded semicolon

Yang Li posted 1 patch 2 months, 1 week ago
drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH -next v2] drm/msm: Remove unneeded semicolon
Posted by Yang Li 2 months, 1 week ago
./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon

This patch removes an unneeded semicolon after a switch statement in the 
pll_get_post_div function. Adding a semicolon after a switch statement is 
unnecessary and can lead to confusion in the code structure.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9852
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
index 0e3a2b16a2ce..65cf237c6b4e 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
@@ -279,7 +279,7 @@ static int pll_get_post_div(struct hdmi_8998_post_divider *pd, u64 bclk)
 	case 25:
 		found_hsclk_divsel = 14;
 		break;
-	};
+	}
 
 	pd->vco_freq = found_vco_freq;
 	pd->tx_band_sel = found_tx_band_sel;
-- 
2.32.0.3.g01195cf9f
Re: [PATCH -next v2] drm/msm: Remove unneeded semicolon
Posted by Dmitry Baryshkov 1 month, 1 week ago
On Wed, 18 Sep 2024 10:33:57 +0800, Yang Li wrote:
> ./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon
> 
> This patch removes an unneeded semicolon after a switch statement in the
> pll_get_post_div function. Adding a semicolon after a switch statement is
> unnecessary and can lead to confusion in the code structure.
> 
> 
> [...]

Applied, thanks!

[1/1] drm/msm: Remove unneeded semicolon
      https://gitlab.freedesktop.org/lumag/msm/-/commit/00adf52efec3

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Re: [PATCH -next v2] drm/msm: Remove unneeded semicolon
Posted by Dmitry Baryshkov 2 months, 1 week ago
On Wed, Sep 18, 2024 at 10:33:57AM GMT, Yang Li wrote:
> ./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon
> 
> This patch removes an unneeded semicolon after a switch statement in the 
> pll_get_post_div function. Adding a semicolon after a switch statement is 
> unnecessary and can lead to confusion in the code structure.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9852
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry