[v1] mfd: da9052-spi: change read-mask to write-mask

[PATCH] mfd: da9052-spi: change read-mask to write-mask

Posted by Marcus Folkesson 2 months, 1 week ago

Actually, the LSB bit is set on write rather than read.
Change it to avoid nasty things to happen.

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
 drivers/mfd/da9052-spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c
index be5f2b34e18aebc7a9506123b366af5a5447df43..80fc5c0cac2fb0e5e99e6db8972f80ae4155b226 100644
--- a/drivers/mfd/da9052-spi.c
+++ b/drivers/mfd/da9052-spi.c
@@ -37,7 +37,7 @@ static int da9052_spi_probe(struct spi_device *spi)
 	spi_set_drvdata(spi, da9052);
 
 	config = da9052_regmap_config;
-	config.read_flag_mask = 1;
+	config.write_flag_mask = 1;
 	config.reg_bits = 7;
 	config.pad_bits = 1;
 	config.val_bits = 8;

---
base-commit: 33cc938e65a98f1d29d0a18403dbbee050dcad9a
change-id: 20240918-da9052-df843a1b9d0e

Best regards,
-- 
Marcus Folkesson <marcus.folkesson@gmail.com>

Re: [PATCH] mfd: da9052-spi: change read-mask to write-mask

Posted by Marcus Folkesson 2 months, 1 week ago

On Wed, Sep 18, 2024 at 11:12:22AM +0200, Marcus Folkesson wrote:
> Actually, the LSB bit is set on write rather than read.
> Change it to avoid nasty things to happen.
> 
Fixes: e9e9d3973594 ("mfd: da9052: Avoid setting read_flag_mask for da9052-i2c driver")
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>

Re: [PATCH] mfd: da9052-spi: change read-mask to write-mask

Posted by Lee Jones 2 months ago

On Thu, 19 Sep 2024, Marcus Folkesson wrote:

> On Wed, Sep 18, 2024 at 11:12:22AM +0200, Marcus Folkesson wrote:
> > Actually, the LSB bit is set on write rather than read.
> > Change it to avoid nasty things to happen.
> > 
> Fixes: e9e9d3973594 ("mfd: da9052: Avoid setting read_flag_mask for da9052-i2c driver")

Please resubmit the patch.

> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>

-- 
Lee Jones [李琼斯]