[v2] arm64: dts: qcom: x1e80100-t14s: add another trackpad support

[PATCH v2] arm64: dts: qcom: x1e80100-t14s: add another trackpad support

Posted by srinivas.kandagatla@linaro.org 2 months, 1 week ago

From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

Trackpad HID device on some of the T14s Product Models 21N2ZC5PUS is
at I2C address 0x2c add this to be able to get it working on these laptops.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
Changes since v1:
- moved pinctrl to parent node so that pinctrl can be claimed globally.

 .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts  | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
index 08ec2419f95f..45a77c1fb6f4 100644
--- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
+++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
@@ -551,6 +551,9 @@ zap-shader {
 &i2c0 {
 	clock-frequency = <400000>;
 
+	pinctrl-0 = <&tpad_default>;
+	pinctrl-names = "default";
+
 	status = "okay";
 
 	/* ELAN06E2 or ELAN06E3 */
@@ -561,13 +564,19 @@ touchpad@15 {
 		hid-descr-addr = <0x1>;
 		interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>;
 
-		pinctrl-0 = <&tpad_default>;
-		pinctrl-names = "default";
-
 		wakeup-source;
 	};
 
-	/* TODO: second-sourced SYNA8022 or SYNA8024 touchpad @ 0x2c */
+	/* SYNA8022 or SYNA8024 */
+	touchpad@2c {
+		compatible = "hid-over-i2c";
+		reg = <0x2c>;
+
+		hid-descr-addr = <0x20>;
+		interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>;
+
+		wakeup-source;
+	};
 
 	/* ELAN06F1 or SYNA06F2 */
 	keyboard@3a {
-- 
2.39.2

Re: [PATCH v2] arm64: dts: qcom: x1e80100-t14s: add another trackpad support

Posted by Konrad Dybcio 2 months, 1 week ago

On 17.09.2024 5:00 PM, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> Trackpad HID device on some of the T14s Product Models 21N2ZC5PUS is
> at I2C address 0x2c add this to be able to get it working on these laptops.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> Changes since v1:
> - moved pinctrl to parent node so that pinctrl can be claimed globally.
> 
>  .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts  | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> index 08ec2419f95f..45a77c1fb6f4 100644
> --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
> @@ -551,6 +551,9 @@ zap-shader {
>  &i2c0 {
>  	clock-frequency = <400000>;
>  
> +	pinctrl-0 = <&tpad_default>;
> +	pinctrl-names = "default";

You're dropping the QUP pins, please include them too (like in c630.dtsi)

Konrad

Re: [PATCH v2] arm64: dts: qcom: x1e80100-t14s: add another trackpad support

Posted by Johan Hovold 2 months, 1 week ago

On Wed, Sep 18, 2024 at 01:32:34AM +0200, Konrad Dybcio wrote:
> On 17.09.2024 5:00 PM, srinivas.kandagatla@linaro.org wrote:
> > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > 
> > Trackpad HID device on some of the T14s Product Models 21N2ZC5PUS is
> > at I2C address 0x2c add this to be able to get it working on these laptops.
> > 
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > ---
> > Changes since v1:
> > - moved pinctrl to parent node so that pinctrl can be claimed globally.

> >  &i2c0 {
> >  	clock-frequency = <400000>;
> >  
> > +	pinctrl-0 = <&tpad_default>;
> > +	pinctrl-names = "default";
> 
> You're dropping the QUP pins, please include them too (like in c630.dtsi)

And make sure to CC people that provide feedback on your patches when
respinning.

Johan

Re: [PATCH v2] arm64: dts: qcom: x1e80100-t14s: add another trackpad support

Posted by Dmitry Baryshkov 2 months, 1 week ago

On Tue, Sep 17, 2024 at 11:00:49AM GMT, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> Trackpad HID device on some of the T14s Product Models 21N2ZC5PUS is
> at I2C address 0x2c add this to be able to get it working on these laptops.

Commit message should describe reasons for moving device-specific
pinctrl to the bus level. Other than that LGTM.

> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> Changes since v1:
> - moved pinctrl to parent node so that pinctrl can be claimed globally.
> 
>  .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts  | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 

-- 
With best wishes
Dmitry