[v2] i2c: isch: Put the driver into shape

[PATCH v2 00/11] i2c: isch: Put the driver into shape

Posted by Andy Shevchenko 2 months, 2 weeks ago

Driver code is quite outdated WRT modern in-kernel APIs and
also has one non-critival bug.

The series is to address the above. Has been tested on
Minnowboard (Intel Tunnel Creek platform) with connected
LM95245 HW monitor chip.

v2:
- dropped applied patch
- fixed format specifier (LKP)

Andy Shevchenko (11):
  i2c: isch: Pass pointer to struct i2c_adapter down
  i2c: isch: Use string_choices API instead of ternary operator
  i2c: isch: Switch to memory mapped IO accessors
  i2c: isch: Use custom private data structure
  i2c: isch: switch i2c registration to devm functions
  i2c: isch: Utilize temporary variable to hold device pointer
  i2c: isch: Use read_poll_timeout()
  i2c: isch: Unify the name of the variable to hold an error code
  i2c: isch: Don't use "proxy" headers
  i2c: isch: Prefer to use octal permission
  i2c: isch: Convert to kernel-doc

 drivers/i2c/busses/i2c-isch.c | 321 +++++++++++++++++-----------------
 1 file changed, 164 insertions(+), 157 deletions(-)

-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v2 00/11] i2c: isch: Put the driver into shape

Posted by Andi Shyti 2 months, 2 weeks ago

Hi Andy,

> Andy Shevchenko (11):
>   i2c: isch: Pass pointer to struct i2c_adapter down
>   i2c: isch: Use string_choices API instead of ternary operator
>   i2c: isch: Switch to memory mapped IO accessors
>   i2c: isch: Use custom private data structure
>   i2c: isch: switch i2c registration to devm functions
>   i2c: isch: Utilize temporary variable to hold device pointer
>   i2c: isch: Use read_poll_timeout()
>   i2c: isch: Unify the name of the variable to hold an error code
>   i2c: isch: Don't use "proxy" headers
>   i2c: isch: Prefer to use octal permission
>   i2c: isch: Convert to kernel-doc

Applied to i2c/i2c-host-for-6.13. These patches will be moved
into i2c/i2c-host after the merge window.

Thanks,
Andi