Add touchscreen and TMP451 tempsensor nodes to Google Pixel C (tegra210-smaug) Device Tree

[PATCH 0/2] Add touchscreen and TMP451 tempsensor nodes to Google Pixel C (tegra210-smaug) Device Tree

Posted by Jasper Korten via B4 Relay 2 months, 2 weeks ago

Information to get these working was gained from downstream DTS.
Link: https://android.googlesource.com/kernel/tegra/+/refs/heads/android-tegra-dragon-3.18-oreo-m8/arch/arm64/boot/dts/tegra/tegra210-smaug.dtsi

Both were missing upstream and easy to add:
- It uses a RMI4 HID-over-I2C compatible touchscreen.
- TMP451 is located close to eMMC according to iFixit's teardown.
  Link: https://www.ifixit.com/Teardown/Google+Pixel+C+Teardown/62277#s290806

This is the first time I've ever submitted patches upstream myself.
If there's anything I've missed or could do better in a new rev,
please let me know!

Signed-off-by: Jasper Korten <jja2000@gmail.com>
---
Jasper Korten (2):
      arm64: dts: nvidia: tegra210-smaug: Add touchscreen node
      arm64: dts: nvidia: tegra210-smaug: Add TMP451 temperature sensor node

 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
---
base-commit: da3ea35007d0af457a0afc87e84fddaebc4e0b63
change-id: 20240915-touch-temp-c64b68961aee

Best regards,
-- 
Jasper Korten <jja2000@gmail.com>

Re: [PATCH 0/2] Add touchscreen and TMP451 tempsensor nodes to Google Pixel C (tegra210-smaug) Device Tree

Posted by Thierry Reding 1 month ago

From: Thierry Reding <treding@nvidia.com>


On Mon, 16 Sep 2024 00:48:12 +0200, Jasper Korten wrote:
> Information to get these working was gained from downstream DTS.
> Link: https://android.googlesource.com/kernel/tegra/+/refs/heads/android-tegra-dragon-3.18-oreo-m8/arch/arm64/boot/dts/tegra/tegra210-smaug.dtsi
> 
> Both were missing upstream and easy to add:
> - It uses a RMI4 HID-over-I2C compatible touchscreen.
> - TMP451 is located close to eMMC according to iFixit's teardown.
>   Link: https://www.ifixit.com/Teardown/Google+Pixel+C+Teardown/62277#s290806
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: nvidia: tegra210-smaug: Add touchscreen node
      commit: c8d63aa0f14adce3d01a3b776b5ea6a33620891d
[2/2] arm64: dts: nvidia: tegra210-smaug: Add TMP451 temperature sensor node
      commit: b219fe91d3140cddb53538c169f7cb2f6f05e75a

Best regards,
-- 
Thierry Reding <treding@nvidia.com>

Re: [PATCH 0/2] Add touchscreen and TMP451 tempsensor nodes to Google Pixel C (tegra210-smaug) Device Tree

Posted by Diogo Ivo 2 months, 1 week ago

On Mon, Sep 16, 2024 at 12:48:12AM GMT, Jasper Korten via B4 Relay wrote:
> Information to get these working was gained from downstream DTS.
> Link: https://android.googlesource.com/kernel/tegra/+/refs/heads/android-tegra-dragon-3.18-oreo-m8/arch/arm64/boot/dts/tegra/tegra210-smaug.dtsi
> 
> Both were missing upstream and easy to add:
> - It uses a RMI4 HID-over-I2C compatible touchscreen.
> - TMP451 is located close to eMMC according to iFixit's teardown.
>   Link: https://www.ifixit.com/Teardown/Google+Pixel+C+Teardown/62277#s290806
> 
> This is the first time I've ever submitted patches upstream myself.
> If there's anything I've missed or could do better in a new rev,
> please let me know!
> 
> Signed-off-by: Jasper Korten <jja2000@gmail.com>

For both patches:

Tested-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>

Thanks!