ARM: dts: omap4-kc1: fix twl6030 power node

[PATCH] ARM: dts: omap4-kc1: fix twl6030 power node

Posted by Andreas Kemnade 2 months, 2 weeks ago

dtbs_check was moaning about twl6030-power, use the standard property
instead.
Apparently that twl6030 power snippet slipped in without the
corresponding driver. Now it is handled by the standard property.

CC: Paul Kocialkowski <contact@paulk.fr>
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/ti/omap/omap4-kc1.dts | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/omap4-kc1.dts b/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
index c6b79ba8bbc91..df874d5f5327f 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
+++ b/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
@@ -112,11 +112,7 @@ twl: twl@48 {
 		reg = <0x48>;
 		/* IRQ# = 7 */
 		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to gic */
-
-		twl_power: power {
-			compatible = "ti,twl6030-power";
-			ti,system-power-controller;
-		};
+		system-power-controller;
 	};
 };
 
-- 
2.39.2

Re: [PATCH] ARM: dts: omap4-kc1: fix twl6030 power node

Posted by Kevin Hilman 1 month, 3 weeks ago

On Sun, 15 Sep 2024 21:35:27 +0200, Andreas Kemnade wrote:
> dtbs_check was moaning about twl6030-power, use the standard property
> instead.
> Apparently that twl6030 power snippet slipped in without the
> corresponding driver. Now it is handled by the standard property.
> 
> 

Applied, thanks!

[1/1] ARM: dts: omap4-kc1: fix twl6030 power node
      commit: 59caaade193003e4dcbc92c82e66906ab7558951

Best regards,
-- 
Kevin Hilman <khilman@baylibre.com>

Re: [PATCH] ARM: dts: omap4-kc1: fix twl6030 power node

Posted by Paul Kocialkowski 2 months, 2 weeks ago

Hi Andreas,

Le Sun 15 Sep 24, 21:35, Andreas Kemnade a écrit :
> dtbs_check was moaning about twl6030-power, use the standard property
> instead.
> Apparently that twl6030 power snippet slipped in without the
> corresponding driver. Now it is handled by the standard property.

Thanks for the fix! LGTM.

Reviewed-by: Paul Kocialkowski <contact@paulk.fr>

Cheers,

Paul

> CC: Paul Kocialkowski <contact@paulk.fr>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/ti/omap/omap4-kc1.dts | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-kc1.dts b/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
> index c6b79ba8bbc91..df874d5f5327f 100644
> --- a/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
> +++ b/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
> @@ -112,11 +112,7 @@ twl: twl@48 {
>  		reg = <0x48>;
>  		/* IRQ# = 7 */
>  		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to gic */
> -
> -		twl_power: power {
> -			compatible = "ti,twl6030-power";
> -			ti,system-power-controller;
> -		};
> +		system-power-controller;
>  	};
>  };
>  
> -- 
> 2.39.2
> 

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expertise in multimedia, graphics and embedded hardware support with Linux.