scsi: bfa: Remove deadcode

[PATCH 0/5] scsi: bfa: Remove deadcode

Posted by linux@treblig.org 2 months, 2 weeks ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

Hi,
  This removes a pile of dead functions in the SCSI bfa driver.
These were spotted by hunting for unused symbols in a unmodular
kernel build, and then double checking by grepping for the function
name.

  It's been build tested only, I don't have the hardware, but
it's strictly full function (and the occasional struct) deletion,
so there should be no change in functionality.

  Thanks to David Hildenbrand for the suggestion of hunting
for unused symbols.

Dave

Dr. David Alan Gilbert (5):
  scsi: bfa: Remove unused bfa_core code
  scsi: bfa: Remove unused bfa_svc code
  scsi: bfa: Remove unused bfa_ioc code
  scsi: bfa: Remove unused bfa_fcs code
  scsi: bfa: Remove unused misc code

 drivers/scsi/bfa/bfa.h           |  10 ---
 drivers/scsi/bfa/bfa_core.c      |  35 --------
 drivers/scsi/bfa/bfa_defs_fcs.h  |  22 -----
 drivers/scsi/bfa/bfa_fcpim.c     |   9 --
 drivers/scsi/bfa/bfa_fcpim.h     |   1 -
 drivers/scsi/bfa/bfa_fcs.h       |  12 ---
 drivers/scsi/bfa/bfa_fcs_lport.c | 142 -------------------------------
 drivers/scsi/bfa/bfa_fcs_rport.c |  36 --------
 drivers/scsi/bfa/bfa_ioc.c       |  21 -----
 drivers/scsi/bfa/bfa_ioc.h       |   2 -
 drivers/scsi/bfa/bfa_modules.h   |   1 -
 drivers/scsi/bfa/bfa_svc.c       |  72 ----------------
 drivers/scsi/bfa/bfa_svc.h       |   5 --
 drivers/scsi/bfa/bfad.c          |  20 -----
 drivers/scsi/bfa/bfad_drv.h      |   1 -
 15 files changed, 389 deletions(-)

-- 
2.46.0

Re: [PATCH 0/5] scsi: bfa: Remove deadcode

Posted by Martin K. Petersen 1 month, 2 weeks ago

>   This removes a pile of dead functions in the SCSI bfa driver.
> These were spotted by hunting for unused symbols in a unmodular
> kernel build, and then double checking by grepping for the function
> name.

Applied to 6.13/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 0/5] scsi: bfa: Remove deadcode

Posted by Dr. David Alan Gilbert 1 month, 2 weeks ago

* Martin K. Petersen (martin.petersen@oracle.com) wrote:
> 
> >   This removes a pile of dead functions in the SCSI bfa driver.
> > These were spotted by hunting for unused symbols in a unmodular
> > kernel build, and then double checking by grepping for the function
> > name.
> 
> Applied to 6.13/scsi-staging, thanks!

Thanks!

Dave

> 
> -- 
> Martin K. Petersen	Oracle Linux Engineering
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH 0/5] scsi: bfa: Remove deadcode

Posted by Dr. David Alan Gilbert 1 month, 2 weeks ago

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> Hi,
>   This removes a pile of dead functions in the SCSI bfa driver.
> These were spotted by hunting for unused symbols in a unmodular
> kernel build, and then double checking by grepping for the function
> name.
> 
>   It's been build tested only, I don't have the hardware, but
> it's strictly full function (and the occasional struct) deletion,
> so there should be no change in functionality.
> 
>   Thanks to David Hildenbrand for the suggestion of hunting
> for unused symbols.
> 
> Dave
> 

Ping; thanks!

> Dr. David Alan Gilbert (5):
>   scsi: bfa: Remove unused bfa_core code
>   scsi: bfa: Remove unused bfa_svc code
>   scsi: bfa: Remove unused bfa_ioc code
>   scsi: bfa: Remove unused bfa_fcs code
>   scsi: bfa: Remove unused misc code
> 
>  drivers/scsi/bfa/bfa.h           |  10 ---
>  drivers/scsi/bfa/bfa_core.c      |  35 --------
>  drivers/scsi/bfa/bfa_defs_fcs.h  |  22 -----
>  drivers/scsi/bfa/bfa_fcpim.c     |   9 --
>  drivers/scsi/bfa/bfa_fcpim.h     |   1 -
>  drivers/scsi/bfa/bfa_fcs.h       |  12 ---
>  drivers/scsi/bfa/bfa_fcs_lport.c | 142 -------------------------------
>  drivers/scsi/bfa/bfa_fcs_rport.c |  36 --------
>  drivers/scsi/bfa/bfa_ioc.c       |  21 -----
>  drivers/scsi/bfa/bfa_ioc.h       |   2 -
>  drivers/scsi/bfa/bfa_modules.h   |   1 -
>  drivers/scsi/bfa/bfa_svc.c       |  72 ----------------
>  drivers/scsi/bfa/bfa_svc.h       |   5 --
>  drivers/scsi/bfa/bfad.c          |  20 -----
>  drivers/scsi/bfa/bfad_drv.h      |   1 -
>  15 files changed, 389 deletions(-)
> 
> -- 
> 2.46.0
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH 0/5] scsi: bfa: Remove deadcode

Posted by Martin K. Petersen 1 month ago

On Sun, 15 Sep 2024 13:56:28 +0100, linux@treblig.org wrote:

>   This removes a pile of dead functions in the SCSI bfa driver.
> These were spotted by hunting for unused symbols in a unmodular
> kernel build, and then double checking by grepping for the function
> name.
> 
>   It's been build tested only, I don't have the hardware, but
> it's strictly full function (and the occasional struct) deletion,
> so there should be no change in functionality.
> 
> [...]

Applied to 6.13/scsi-queue, thanks!

[1/5] scsi: bfa: Remove unused bfa_core code
      https://git.kernel.org/mkp/scsi/c/f3845d7d7145
[2/5] scsi: bfa: Remove unused bfa_svc code
      https://git.kernel.org/mkp/scsi/c/0604cf11cd56
[3/5] scsi: bfa: Remove unused bfa_ioc code
      https://git.kernel.org/mkp/scsi/c/b74448006a67
[4/5] scsi: bfa: Remove unused bfa_fcs code
      https://git.kernel.org/mkp/scsi/c/372dcc01616e
[5/5] scsi: bfa: Remove unused misc code
      https://git.kernel.org/mkp/scsi/c/8d7cfe95217c

-- 
Martin K. Petersen	Oracle Linux Engineering