[v1] ethernet: chelsio: fix a typo

[PATCH] ethernet: chelsio: fix a typo

Posted by Andrew Kreimer 2 months, 2 weeks ago

Fix a typo in comments.

Reported-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
 drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h b/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h
index 4c883170683b..ad82119db20b 100644
--- a/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h
+++ b/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h
@@ -49,7 +49,7 @@
 /******************************************************************************/
 /** S/UNI-1x10GE-XP REGISTER ADDRESS MAP                                     **/
 /******************************************************************************/
-/* Refer to the Register Bit Masks bellow for the naming of each register and */
+/* Refer to the Register Bit Masks below for the naming of each register and */
 /* to the S/UNI-1x10GE-XP Data Sheet for the signification of each bit        */
 /******************************************************************************/
 
-- 
2.39.5

Re: [PATCH] ethernet: chelsio: fix a typo

Posted by Christophe JAILLET 2 months, 2 weeks ago

Le 15/09/2024 à 14:52, Andrew Kreimer a écrit :
> Fix a typo in comments.
> 
> Reported-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> ---
>   drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h b/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h
> index 4c883170683b..ad82119db20b 100644
> --- a/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h
> +++ b/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h
> @@ -49,7 +49,7 @@
>   /******************************************************************************/
>   /** S/UNI-1x10GE-XP REGISTER ADDRESS MAP                                     **/
>   /******************************************************************************/
> -/* Refer to the Register Bit Masks bellow for the naming of each register and */
> +/* Refer to the Register Bit Masks below for the naming of each register and */
>   /* to the S/UNI-1x10GE-XP Data Sheet for the signification of each bit        */
>   /******************************************************************************/
>   

Hi,

Nitpick: a space should be added between "and" and "*/" to keep a nice 
layout.

CJ

Re: [PATCH] ethernet: chelsio: fix a typo

Posted by Andrew Kreimer 2 months, 2 weeks ago

On Sun, Sep 15, 2024 at 02:56:59PM +0200, Christophe JAILLET wrote:
> Le 15/09/2024 à 14:52, Andrew Kreimer a écrit :
> > Fix a typo in comments.
> > 
> > Reported-by: Matthew Wilcox <willy@infradead.org>
> > Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> > ---
> >   drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h b/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h
> > index 4c883170683b..ad82119db20b 100644
> > --- a/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h
> > +++ b/drivers/net/ethernet/chelsio/cxgb/suni1x10gexp_regs.h
> > @@ -49,7 +49,7 @@
> >   /******************************************************************************/
> >   /** S/UNI-1x10GE-XP REGISTER ADDRESS MAP                                     **/
> >   /******************************************************************************/
> > -/* Refer to the Register Bit Masks bellow for the naming of each register and */
> > +/* Refer to the Register Bit Masks below for the naming of each register and */
> >   /* to the S/UNI-1x10GE-XP Data Sheet for the signification of each bit        */
> >   /******************************************************************************/
> 
> Hi,
> 
> Nitpick: a space should be added between "and" and "*/" to keep a nice
> layout.

Absolutely.

> 
> CJ