Fix bpf_get/setsockopt failed when TCP over IPv4 via INET6 API

[PATCH bpf-next v3 0/2] Fix bpf_get/setsockopt failed when TCP over IPv4 via INET6 API

Feng zhou posted 2 patches 2 months, 2 weeks ago

Download series mbox

net/core/filter.c                             |  7 +++-
.../selftests/bpf/prog_tests/setget_sockopt.c | 33 +++++++++++++++++++
.../selftests/bpf/progs/setget_sockopt.c      | 13 ++++++--
3 files changed, 49 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH bpf-next v3 0/2] Fix bpf_get/setsockopt failed when TCP over IPv4 via INET6 API

Posted by Feng zhou 2 months, 2 weeks ago

From: Feng Zhou <zhoufeng.zf@bytedance.com>

When TCP over IPv4 via INET6 API, sk->sk_family is AF_INET6, but it is a v4 pkt.
inet_csk(sk)->icsk_af_ops is ipv6_mapped and use ip_queue_xmit. Some sockopt did
not take effect, such as tos.

0001: Use sk_is_inet helper to fix it.
0002: Setget_sockopt add a test for tcp over ipv4 via ipv6.

Changelog:
v2->v3: Addressed comments from Eric Dumazet
- Use sk_is_inet() helper
Details in here:
https://lore.kernel.org/bpf/CANn89i+9GmBLCdgsfH=WWe-tyFYpiO27wONyxaxiU6aOBC6G8g@mail.gmail.com/T/

v1->v2: Addressed comments from kernel test robot
- Fix compilation error
Details in here:
https://lore.kernel.org/bpf/202408152058.YXAnhLgZ-lkp@intel.com/T/

Feng Zhou (2):
  bpf: Fix bpf_get/setsockopt to tos not take effect when TCP over IPv4
    via INET6 API
  selftests/bpf: Setget_sockopt add a test for tcp over ipv4 via ipv6

 net/core/filter.c                             |  7 +++-
 .../selftests/bpf/prog_tests/setget_sockopt.c | 33 +++++++++++++++++++
 .../selftests/bpf/progs/setget_sockopt.c      | 13 ++++++--
 3 files changed, 49 insertions(+), 4 deletions(-)

-- 
2.30.2