[PATCH v5 1/2] dt-bindings: arm: rockchip: Add RK3588S EVB1 board

Damon Ding posted 2 patches 2 months, 2 weeks ago
[PATCH v5 1/2] dt-bindings: arm: rockchip: Add RK3588S EVB1 board
Posted by Damon Ding 2 months, 2 weeks ago
Add devicetree binding for the Rockchip RK3588S evaluation board.

RK3588S EVB1 board features:
- Rockchip RK3588S
- PMIC: RK806-2x2pcs+DiscretePower
- RAM: LPDDR4/4x 2pcsx 32bit
- ROM: eMMC5.1+ SPI Falsh

Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
---

Changes in v4:
- Add more detailed comments in commit message

 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 1ef09fbfdfaf..4f6e24fcc765 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -942,6 +942,11 @@ properties:
           - const: rockchip,rk3588-evb1-v10
           - const: rockchip,rk3588
 
+      - description: Rockchip RK3588S Evaluation board
+        items:
+          - const: rockchip,rk3588s-evb1-v10
+          - const: rockchip,rk3588s
+
       - description: Rockchip RV1108 Evaluation board
         items:
           - const: rockchip,rv1108-evb
-- 
2.34.1
Re: [PATCH v5 1/2] dt-bindings: arm: rockchip: Add RK3588S EVB1 board
Posted by Krzysztof Kozlowski 2 months, 2 weeks ago
On Sat, Sep 14, 2024 at 05:54:55PM +0800, Damon Ding wrote:
> Add devicetree binding for the Rockchip RK3588S evaluation board.
> 
> RK3588S EVB1 board features:
> - Rockchip RK3588S
> - PMIC: RK806-2x2pcs+DiscretePower
> - RAM: LPDDR4/4x 2pcsx 32bit
> - ROM: eMMC5.1+ SPI Falsh
> 
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
> ---
> 

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation: Please add
Acked-by/Reviewed-by/Tested-by tags when posting new versions, under
or above your Signed-off-by tag. Tag is "received", when provided
in a message replied to you on the mailing list. Tools like b4 can help
here. However, there's no need to repost patches *only* to add the tags.
The upstream maintainer will do that for tags received on the version
they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH v5 1/2] dt-bindings: arm: rockchip: Add RK3588S EVB1 board
Posted by Damon Ding 2 months, 1 week ago
Hi Krzysztof:

On 2024/9/16 16:49, Krzysztof Kozlowski wrote:
> On Sat, Sep 14, 2024 at 05:54:55PM +0800, Damon Ding wrote:
>> Add devicetree binding for the Rockchip RK3588S evaluation board.
>>
>> RK3588S EVB1 board features:
>> - Rockchip RK3588S
>> - PMIC: RK806-2x2pcs+DiscretePower
>> - RAM: LPDDR4/4x 2pcsx 32bit
>> - ROM: eMMC5.1+ SPI Falsh
>>
>> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
>> ---
>>
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation: Please add
> Acked-by/Reviewed-by/Tested-by tags when posting new versions, under
> or above your Signed-off-by tag. Tag is "received", when provided
> in a message replied to you on the mailing list. Tools like b4 can help
> here. However, there's no need to repost patches *only* to add the tags.
> The upstream maintainer will do that for tags received on the version
> they apply.
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 
> 

Thank you for your friendly reminder and the detailed explanation about 
the tag. I did forget to add the tag in v5 patch, and I will pay more 
attention to this in future updates.

Best regards,
Damon