arm64: dts: allwinner: h5: NanoPi NEO Plus2: Add disable-wp to mmc0

[PATCH] arm64: dts: allwinner: h5: NanoPi NEO Plus2: Add disable-wp to mmc0

Posted by Kryštof Černý 1 year, 4 months ago

The board does not have wp pin/switch for micro SD card (mmc0).

Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
index 526443bb736c..18fa541795a6 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
@@ -136,6 +136,7 @@ &mmc0 {
 	vmmc-supply = <&reg_vcc3v3>;
 	bus-width = <4>;
 	cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
+	disable-wp;
 	status = "okay";
 };
 

---
base-commit: 57f962b956f1d116cd64d5c406776c4975de549d
change-id: 20240914-b4-nanopineoplus2-fix-mmc0-wp-9d77fb9e6513

Best regards,
-- 
Kryštof Černý <cleverline1mc@gmail.com>

Re: [PATCH] arm64: dts: allwinner: h5: NanoPi NEO Plus2: Add disable-wp to mmc0

Posted by Andre Przywara 1 year, 4 months ago

On Sat, 14 Sep 2024 12:07:00 +0200
Kryštof Černý <cleverline1mc@gmail.com> wrote:

> The board does not have wp pin/switch for micro SD card (mmc0).

That is true, but for *every* microSD card. So I wonder if we should add
this property to all of the boards? I believe none of the arm64 boards have
full size SD card slots?

Cheers,
Andre

> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> index 526443bb736c..18fa541795a6 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> @@ -136,6 +136,7 @@ &mmc0 {
>  	vmmc-supply = <&reg_vcc3v3>;
>  	bus-width = <4>;
>  	cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
> +	disable-wp;
>  	status = "okay";
>  };
>  
> 
> ---
> base-commit: 57f962b956f1d116cd64d5c406776c4975de549d
> change-id: 20240914-b4-nanopineoplus2-fix-mmc0-wp-9d77fb9e6513
> 
> Best regards,