[v2] ACPI: thermal: Use strscpy() instead of strcpy()

[PATCH v2] ACPI: thermal: Use strscpy() instead of strcpy()

Abdul Rahim posted 1 patch 2 months, 2 weeks ago

Diff against v1 v1
Download mbox

drivers/acpi/thermal.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH v2] ACPI: thermal: Use strscpy() instead of strcpy()

Posted by Abdul Rahim 2 months, 2 weeks ago

strcpy() is generally considered unsafe and use of strscpy() is
recommended [1]

this fixes checkpatch warning:
	WARNING: Prefer strscpy over strcpy

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com>
---

Changes in v2:

    - Remove an unneeded extra parameter (MAX_ACPI_DEVICE_NAME_LEN) in
      the 2nd strscpy() call

v1:
https://lore.kernel.org/all/20240912205922.302036-1-abdul.rahim@myyahoo.com/

 drivers/acpi/thermal.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index 78db38c7076e..6671537cb4b7 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -796,9 +796,9 @@ static int acpi_thermal_add(struct acpi_device *device)
 		return -ENOMEM;
 
 	tz->device = device;
-	strcpy(tz->name, device->pnp.bus_id);
-	strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
-	strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
+	strscpy(tz->name, device->pnp.bus_id);
+	strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
+	strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
 	device->driver_data = tz;
 
 	acpi_thermal_aml_dependency_fix(tz);
-- 
2.46.0