[PATCH] scsi: aic7xxx: Remove unused aic7770_find_device

linux@treblig.org posted 1 patch 2 months, 2 weeks ago
drivers/scsi/aic7xxx/aic7770.c | 15 ---------------
drivers/scsi/aic7xxx/aic7xxx.h |  2 --
2 files changed, 17 deletions(-)
[PATCH] scsi: aic7xxx: Remove unused aic7770_find_device
Posted by linux@treblig.org 2 months, 2 weeks ago
From: "Dr. David Alan Gilbert" <linux@treblig.org>

'aic7770_find_device' has been unused since 2005's
  commit dedd83108105 ("[SCSI] aic7xxx: remove Linux 2.4 ifdefs")

Remove it and the associated constant.
(Whether anyone still has one of these cards in use is another question,
I've just build tested this).

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/scsi/aic7xxx/aic7770.c | 15 ---------------
 drivers/scsi/aic7xxx/aic7xxx.h |  2 --
 2 files changed, 17 deletions(-)

diff --git a/drivers/scsi/aic7xxx/aic7770.c b/drivers/scsi/aic7xxx/aic7770.c
index 176704b24e6a..f1ce02cd569e 100644
--- a/drivers/scsi/aic7xxx/aic7770.c
+++ b/drivers/scsi/aic7xxx/aic7770.c
@@ -99,21 +99,6 @@ struct aic7770_identity aic7770_ident_table[] =
 		ahc_aic7770_EISA_setup
 	}
 };
-const int ahc_num_aic7770_devs = ARRAY_SIZE(aic7770_ident_table);
-
-struct aic7770_identity *
-aic7770_find_device(uint32_t id)
-{
-	struct	aic7770_identity *entry;
-	int	i;
-
-	for (i = 0; i < ahc_num_aic7770_devs; i++) {
-		entry = &aic7770_ident_table[i];
-		if (entry->full_id == (id & entry->id_mask))
-			return (entry);
-	}
-	return (NULL);
-}
 
 int
 aic7770_config(struct ahc_softc *ahc, struct aic7770_identity *entry, u_int io)
diff --git a/drivers/scsi/aic7xxx/aic7xxx.h b/drivers/scsi/aic7xxx/aic7xxx.h
index 9bc755a0a2d3..20857c213c72 100644
--- a/drivers/scsi/aic7xxx/aic7xxx.h
+++ b/drivers/scsi/aic7xxx/aic7xxx.h
@@ -1119,7 +1119,6 @@ struct aic7770_identity {
 	ahc_device_setup_t	*setup;
 };
 extern struct aic7770_identity aic7770_ident_table[];
-extern const int ahc_num_aic7770_devs;
 
 #define AHC_EISA_SLOT_OFFSET	0xc00
 #define AHC_EISA_IOSIZE		0x100
@@ -1135,7 +1134,6 @@ int			 ahc_pci_test_register_access(struct ahc_softc *);
 void __maybe_unused	 ahc_pci_resume(struct ahc_softc *ahc);
 
 /*************************** EISA/VL Front End ********************************/
-struct aic7770_identity *aic7770_find_device(uint32_t);
 int			 aic7770_config(struct ahc_softc *ahc,
 					struct aic7770_identity *,
 					u_int port);
-- 
2.46.0
Re: [PATCH] scsi: aic7xxx: Remove unused aic7770_find_device
Posted by Martin K. Petersen 1 month, 2 weeks ago
On Fri, 13 Sep 2024 18:01:16 +0100, linux@treblig.org wrote:

> 'aic7770_find_device' has been unused since 2005's
>   commit dedd83108105 ("[SCSI] aic7xxx: remove Linux 2.4 ifdefs")
> 
> Remove it and the associated constant.
> (Whether anyone still has one of these cards in use is another question,
> I've just build tested this).
> 
> [...]

Applied to 6.13/scsi-queue, thanks!

[1/1] scsi: aic7xxx: Remove unused aic7770_find_device
      https://git.kernel.org/mkp/scsi/c/0b1e535598d5

-- 
Martin K. Petersen	Oracle Linux Engineering
Re: [PATCH] scsi: aic7xxx: Remove unused aic7770_find_device
Posted by Martin K. Petersen 1 month, 3 weeks ago
> 'aic7770_find_device' has been unused since 2005's
>   commit dedd83108105 ("[SCSI] aic7xxx: remove Linux 2.4 ifdefs")

Applied to 6.13/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering