1. Patchew
  2. linux
  3. View series

[PATCH] crypto: Removing CRYPTO_AES_GCM_P10.

Danny Tsen posted 1 patch 2 months, 2 weeks ago
There is a newer version of this series
arch/powerpc/crypto/Kconfig | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
[PATCH] crypto: Removing CRYPTO_AES_GCM_P10.
Posted by Danny Tsen 2 months, 2 weeks ago 
Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the
subsequent patches to fix data mismatch over ipsec tunnel.

Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
---
 arch/powerpc/crypto/Kconfig | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
index 09ebcbdfb34f..96ca2c4c8827 100644
--- a/arch/powerpc/crypto/Kconfig
+++ b/arch/powerpc/crypto/Kconfig
@@ -105,22 +105,22 @@ config CRYPTO_AES_PPC_SPE
 	  architecture specific assembler implementations that work on 1KB
 	  tables or 256 bytes S-boxes.
 
-config CRYPTO_AES_GCM_P10
-	tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
-	depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
-	select CRYPTO_LIB_AES
-	select CRYPTO_ALGAPI
-	select CRYPTO_AEAD
-	select CRYPTO_SKCIPHER
-	help
-	  AEAD cipher: AES cipher algorithms (FIPS-197)
-	  GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
-	  Architecture: powerpc64 using:
-	    - little-endian
-	    - Power10 or later features
-
-	  Support for cryptographic acceleration instructions on Power10 or
-	  later CPU. This module supports stitched acceleration for AES/GCM.
+#config CRYPTO_AES_GCM_P10
+#	tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
+#	depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
+#	select CRYPTO_LIB_AES
+#	select CRYPTO_ALGAPI
+#	select CRYPTO_AEAD
+#	select CRYPTO_SKCIPHER
+#	help
+#	  AEAD cipher: AES cipher algorithms (FIPS-197)
+#	  GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
+#	  Architecture: powerpc64 using:
+#	    - little-endian
+#	    - Power10 or later features
+#
+#	  Support for cryptographic acceleration instructions on Power10 or
+#	  later CPU. This module supports stitched acceleration for AES/GCM.
 
 config CRYPTO_CHACHA20_P10
 	tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)"
-- 
2.43.0
Re: [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.
Posted by Michael Ellerman 2 months, 1 week ago 
Danny Tsen <dtsen@linux.ibm.com> writes:
> Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the
> subsequent patches to fix data mismatch over ipsec tunnel.

This change log needs to stand on its own. ie. it needs to explain what
the problem is and why the feature is being disabled, without reference
to subsequent patches (which will probably be merged separately).

It should also have a Fixes/stable tag.

And as Christophe said, just adding a dependency on BROKEN is
sufficient.

cheers


> diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
> index 09ebcbdfb34f..96ca2c4c8827 100644
> --- a/arch/powerpc/crypto/Kconfig
> +++ b/arch/powerpc/crypto/Kconfig
> @@ -105,22 +105,22 @@ config CRYPTO_AES_PPC_SPE
>  	  architecture specific assembler implementations that work on 1KB
>  	  tables or 256 bytes S-boxes.
>  
> -config CRYPTO_AES_GCM_P10
> -	tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
> -	depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
> -	select CRYPTO_LIB_AES
> -	select CRYPTO_ALGAPI
> -	select CRYPTO_AEAD
> -	select CRYPTO_SKCIPHER
> -	help
> -	  AEAD cipher: AES cipher algorithms (FIPS-197)
> -	  GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
> -	  Architecture: powerpc64 using:
> -	    - little-endian
> -	    - Power10 or later features
> -
> -	  Support for cryptographic acceleration instructions on Power10 or
> -	  later CPU. This module supports stitched acceleration for AES/GCM.
> +#config CRYPTO_AES_GCM_P10
> +#	tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
> +#	depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
> +#	select CRYPTO_LIB_AES
> +#	select CRYPTO_ALGAPI
> +#	select CRYPTO_AEAD
> +#	select CRYPTO_SKCIPHER
> +#	help
> +#	  AEAD cipher: AES cipher algorithms (FIPS-197)
> +#	  GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
> +#	  Architecture: powerpc64 using:
> +#	    - little-endian
> +#	    - Power10 or later features
> +#
> +#	  Support for cryptographic acceleration instructions on Power10 or
> +#	  later CPU. This module supports stitched acceleration for AES/GCM.
>  
>  config CRYPTO_CHACHA20_P10
>  	tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)"
> -- 
> 2.43.0
Re: [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.
Posted by Danny Tsen 2 months, 1 week ago 
Thanks Michael.

On 9/18/24 11:55 PM, Michael Ellerman wrote:
> Danny Tsen <dtsen@linux.ibm.com> writes:
>> Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the
>> subsequent patches to fix data mismatch over ipsec tunnel.
> This change log needs to stand on its own. ie. it needs to explain what
> the problem is and why the feature is being disabled, without reference
> to subsequent patches (which will probably be merged separately).
>
> It should also have a Fixes/stable tag.
>
> And as Christophe said, just adding a dependency on BROKEN is
> sufficient.
>
> cheers
>
>
>> diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
>> index 09ebcbdfb34f..96ca2c4c8827 100644
>> --- a/arch/powerpc/crypto/Kconfig
>> +++ b/arch/powerpc/crypto/Kconfig
>> @@ -105,22 +105,22 @@ config CRYPTO_AES_PPC_SPE
>>   	  architecture specific assembler implementations that work on 1KB
>>   	  tables or 256 bytes S-boxes.
>>   
>> -config CRYPTO_AES_GCM_P10
>> -	tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
>> -	depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
>> -	select CRYPTO_LIB_AES
>> -	select CRYPTO_ALGAPI
>> -	select CRYPTO_AEAD
>> -	select CRYPTO_SKCIPHER
>> -	help
>> -	  AEAD cipher: AES cipher algorithms (FIPS-197)
>> -	  GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
>> -	  Architecture: powerpc64 using:
>> -	    - little-endian
>> -	    - Power10 or later features
>> -
>> -	  Support for cryptographic acceleration instructions on Power10 or
>> -	  later CPU. This module supports stitched acceleration for AES/GCM.
>> +#config CRYPTO_AES_GCM_P10
>> +#	tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
>> +#	depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
>> +#	select CRYPTO_LIB_AES
>> +#	select CRYPTO_ALGAPI
>> +#	select CRYPTO_AEAD
>> +#	select CRYPTO_SKCIPHER
>> +#	help
>> +#	  AEAD cipher: AES cipher algorithms (FIPS-197)
>> +#	  GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
>> +#	  Architecture: powerpc64 using:
>> +#	    - little-endian
>> +#	    - Power10 or later features
>> +#
>> +#	  Support for cryptographic acceleration instructions on Power10 or
>> +#	  later CPU. This module supports stitched acceleration for AES/GCM.
>>   
>>   config CRYPTO_CHACHA20_P10
>>   	tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)"
>> -- 
>> 2.43.0
Re: [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.
Posted by Christophe Leroy 2 months, 2 weeks ago 

Le 13/09/2024 à 14:30, Danny Tsen a écrit :
> [Vous ne recevez pas souvent de courriers de dtsen@linux.ibm.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the
> subsequent patches to fix data mismatch over ipsec tunnel.

To deactivate a driver, all you have to do is to add:

	depends on BROKEN

Christophe


> 
> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
> ---
>   arch/powerpc/crypto/Kconfig | 32 ++++++++++++++++----------------
>   1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
> index 09ebcbdfb34f..96ca2c4c8827 100644
> --- a/arch/powerpc/crypto/Kconfig
> +++ b/arch/powerpc/crypto/Kconfig
> @@ -105,22 +105,22 @@ config CRYPTO_AES_PPC_SPE
>            architecture specific assembler implementations that work on 1KB
>            tables or 256 bytes S-boxes.
> 
> -config CRYPTO_AES_GCM_P10
> -       tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
> -       depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
> -       select CRYPTO_LIB_AES
> -       select CRYPTO_ALGAPI
> -       select CRYPTO_AEAD
> -       select CRYPTO_SKCIPHER
> -       help
> -         AEAD cipher: AES cipher algorithms (FIPS-197)
> -         GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
> -         Architecture: powerpc64 using:
> -           - little-endian
> -           - Power10 or later features
> -
> -         Support for cryptographic acceleration instructions on Power10 or
> -         later CPU. This module supports stitched acceleration for AES/GCM.
> +#config CRYPTO_AES_GCM_P10
> +#      tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
> +#      depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
> +#      select CRYPTO_LIB_AES
> +#      select CRYPTO_ALGAPI
> +#      select CRYPTO_AEAD
> +#      select CRYPTO_SKCIPHER
> +#      help
> +#        AEAD cipher: AES cipher algorithms (FIPS-197)
> +#        GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
> +#        Architecture: powerpc64 using:
> +#          - little-endian
> +#          - Power10 or later features
> +#
> +#        Support for cryptographic acceleration instructions on Power10 or
> +#        later CPU. This module supports stitched acceleration for AES/GCM.
> 
>   config CRYPTO_CHACHA20_P10
>          tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or later)"
> --
> 2.43.0
> 
>
Re: [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.
Posted by Danny Tsen 2 months, 2 weeks ago 
Got it.  Thanks.

-Danny

On 9/13/24 8:55 AM, Christophe Leroy wrote:
>
>
> Le 13/09/2024 à 14:30, Danny Tsen a écrit :
>> [Vous ne recevez pas souvent de courriers de dtsen@linux.ibm.com. 
>> Découvrez pourquoi ceci est important à 
>> https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the
>> subsequent patches to fix data mismatch over ipsec tunnel.
>
> To deactivate a driver, all you have to do is to add:
>
>     depends on BROKEN
>
> Christophe
>
>
>>
>> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
>> ---
>>   arch/powerpc/crypto/Kconfig | 32 ++++++++++++++++----------------
>>   1 file changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
>> index 09ebcbdfb34f..96ca2c4c8827 100644
>> --- a/arch/powerpc/crypto/Kconfig
>> +++ b/arch/powerpc/crypto/Kconfig
>> @@ -105,22 +105,22 @@ config CRYPTO_AES_PPC_SPE
>>            architecture specific assembler implementations that work 
>> on 1KB
>>            tables or 256 bytes S-boxes.
>>
>> -config CRYPTO_AES_GCM_P10
>> -       tristate "Stitched AES/GCM acceleration support on P10 or 
>> later CPU (PPC)"
>> -       depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
>> -       select CRYPTO_LIB_AES
>> -       select CRYPTO_ALGAPI
>> -       select CRYPTO_AEAD
>> -       select CRYPTO_SKCIPHER
>> -       help
>> -         AEAD cipher: AES cipher algorithms (FIPS-197)
>> -         GCM (Galois/Counter Mode) authenticated encryption mode 
>> (NIST SP800-38D)
>> -         Architecture: powerpc64 using:
>> -           - little-endian
>> -           - Power10 or later features
>> -
>> -         Support for cryptographic acceleration instructions on 
>> Power10 or
>> -         later CPU. This module supports stitched acceleration for 
>> AES/GCM.
>> +#config CRYPTO_AES_GCM_P10
>> +#      tristate "Stitched AES/GCM acceleration support on P10 or 
>> later CPU (PPC)"
>> +#      depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
>> +#      select CRYPTO_LIB_AES
>> +#      select CRYPTO_ALGAPI
>> +#      select CRYPTO_AEAD
>> +#      select CRYPTO_SKCIPHER
>> +#      help
>> +#        AEAD cipher: AES cipher algorithms (FIPS-197)
>> +#        GCM (Galois/Counter Mode) authenticated encryption mode 
>> (NIST SP800-38D)
>> +#        Architecture: powerpc64 using:
>> +#          - little-endian
>> +#          - Power10 or later features
>> +#
>> +#        Support for cryptographic acceleration instructions on 
>> Power10 or
>> +#        later CPU. This module supports stitched acceleration for 
>> AES/GCM.
>>
>>   config CRYPTO_CHACHA20_P10
>>          tristate "Ciphers: ChaCha20, XChacha20, XChacha12 (P10 or 
>> later)"
>> -- 
>> 2.43.0
>>
>>

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.