[v2] um: Fix the return value of elf_core_copy_task_fpregs

[PATCH v2] um: Fix the return value of elf_core_copy_task_fpregs

Tiwei Bie posted 1 patch 2 months, 2 weeks ago

Diff against v1
Download mbox

arch/um/kernel/process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH v2] um: Fix the return value of elf_core_copy_task_fpregs

Posted by Tiwei Bie 2 months, 2 weeks ago

This function is expected to return a boolean value, which should be
true on success and false on failure.

Fixes: d1254b12c93e ("uml: fix x86_64 core dump crash")
Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
---
v2:
- Drop the unnecessary new variable (suggested by Richard Weinberger);

 arch/um/kernel/process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/um/kernel/process.c b/arch/um/kernel/process.c
index be2856af6d4c..9c6cf03ed02b 100644
--- a/arch/um/kernel/process.c
+++ b/arch/um/kernel/process.c
@@ -292,6 +292,6 @@ int elf_core_copy_task_fpregs(struct task_struct *t, elf_fpregset_t *fpu)
 {
 	int cpu = current_thread_info()->cpu;
 
-	return save_i387_registers(userspace_pid[cpu], (unsigned long *) fpu);
+	return save_i387_registers(userspace_pid[cpu], (unsigned long *) fpu) == 0;
 }
 
-- 
2.34.1