x86/boot: Remove unused function 'atou'

[PATCH] x86/boot: Remove unused function 'atou'

Posted by linux@treblig.org 2 months, 2 weeks ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

I can't find any sign of 'atou' having been used.
Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 arch/x86/boot/boot.h   | 1 -
 arch/x86/boot/string.c | 8 --------
 arch/x86/boot/string.h | 1 -
 3 files changed, 10 deletions(-)

diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h
index 148ba5c5106e..0f24f7ebec9b 100644
--- a/arch/x86/boot/boot.h
+++ b/arch/x86/boot/boot.h
@@ -305,7 +305,6 @@ void initregs(struct biosregs *regs);
 int strcmp(const char *str1, const char *str2);
 int strncmp(const char *cs, const char *ct, size_t count);
 size_t strnlen(const char *s, size_t maxlen);
-unsigned int atou(const char *s);
 unsigned long long simple_strtoull(const char *cp, char **endp, unsigned int base);
 size_t strlen(const char *s);
 char *strchr(const char *s, int c);
diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
index c23f3b9c84fe..84f7a883ce1e 100644
--- a/arch/x86/boot/string.c
+++ b/arch/x86/boot/string.c
@@ -88,14 +88,6 @@ size_t strnlen(const char *s, size_t maxlen)
 	return (es - s);
 }
 
-unsigned int atou(const char *s)
-{
-	unsigned int i = 0;
-	while (isdigit(*s))
-		i = i * 10 + (*s++ - '0');
-	return i;
-}
-
 /* Works only for digits and letters, but small and fast */
 #define TOLOWER(x) ((x) | 0x20)
 
diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
index e5d2c6b8c2f1..a5b05ebc037d 100644
--- a/arch/x86/boot/string.h
+++ b/arch/x86/boot/string.h
@@ -24,7 +24,6 @@ extern size_t strlen(const char *s);
 extern char *strstr(const char *s1, const char *s2);
 extern char *strchr(const char *s, int c);
 extern size_t strnlen(const char *s, size_t maxlen);
-extern unsigned int atou(const char *s);
 extern unsigned long long simple_strtoull(const char *cp, char **endp,
 					  unsigned int base);
 long simple_strtol(const char *cp, char **endp, unsigned int base);
-- 
2.46.0

Re: [PATCH] x86/boot: Remove unused function 'atou'

Posted by Dr. David Alan Gilbert 1 month, 2 weeks ago

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> I can't find any sign of 'atou' having been used.
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping

Dave

> ---
>  arch/x86/boot/boot.h   | 1 -
>  arch/x86/boot/string.c | 8 --------
>  arch/x86/boot/string.h | 1 -
>  3 files changed, 10 deletions(-)
> 
> diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h
> index 148ba5c5106e..0f24f7ebec9b 100644
> --- a/arch/x86/boot/boot.h
> +++ b/arch/x86/boot/boot.h
> @@ -305,7 +305,6 @@ void initregs(struct biosregs *regs);
>  int strcmp(const char *str1, const char *str2);
>  int strncmp(const char *cs, const char *ct, size_t count);
>  size_t strnlen(const char *s, size_t maxlen);
> -unsigned int atou(const char *s);
>  unsigned long long simple_strtoull(const char *cp, char **endp, unsigned int base);
>  size_t strlen(const char *s);
>  char *strchr(const char *s, int c);
> diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
> index c23f3b9c84fe..84f7a883ce1e 100644
> --- a/arch/x86/boot/string.c
> +++ b/arch/x86/boot/string.c
> @@ -88,14 +88,6 @@ size_t strnlen(const char *s, size_t maxlen)
>  	return (es - s);
>  }
>  
> -unsigned int atou(const char *s)
> -{
> -	unsigned int i = 0;
> -	while (isdigit(*s))
> -		i = i * 10 + (*s++ - '0');
> -	return i;
> -}
> -
>  /* Works only for digits and letters, but small and fast */
>  #define TOLOWER(x) ((x) | 0x20)
>  
> diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
> index e5d2c6b8c2f1..a5b05ebc037d 100644
> --- a/arch/x86/boot/string.h
> +++ b/arch/x86/boot/string.h
> @@ -24,7 +24,6 @@ extern size_t strlen(const char *s);
>  extern char *strstr(const char *s1, const char *s2);
>  extern char *strchr(const char *s, int c);
>  extern size_t strnlen(const char *s, size_t maxlen);
> -extern unsigned int atou(const char *s);
>  extern unsigned long long simple_strtoull(const char *cp, char **endp,
>  					  unsigned int base);
>  long simple_strtol(const char *cp, char **endp, unsigned int base);
> -- 
> 2.46.0
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

[tip: x86/cleanups] x86/boot: Remove unused function atou()

Posted by tip-bot2 for Dr. David Alan Gilbert 3 weeks, 1 day ago

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID:     97ecb260d9c19aa044871ae2c89408c340717b61
Gitweb:        https://git.kernel.org/tip/97ecb260d9c19aa044871ae2c89408c340717b61
Author:        Dr. David Alan Gilbert <linux@treblig.org>
AuthorDate:    Fri, 13 Sep 2024 01:57:53 +01:00
Committer:     Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Thu, 07 Nov 2024 18:08:23 +01:00

x86/boot: Remove unused function atou()

I can't find any sign of atou() having been used. Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20240913005753.1392431-1-linux@treblig.org
---
 arch/x86/boot/boot.h   | 1 -
 arch/x86/boot/string.c | 8 --------
 arch/x86/boot/string.h | 1 -
 3 files changed, 10 deletions(-)

diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h
index 148ba5c..0f24f7e 100644
--- a/arch/x86/boot/boot.h
+++ b/arch/x86/boot/boot.h
@@ -305,7 +305,6 @@ void initregs(struct biosregs *regs);
 int strcmp(const char *str1, const char *str2);
 int strncmp(const char *cs, const char *ct, size_t count);
 size_t strnlen(const char *s, size_t maxlen);
-unsigned int atou(const char *s);
 unsigned long long simple_strtoull(const char *cp, char **endp, unsigned int base);
 size_t strlen(const char *s);
 char *strchr(const char *s, int c);
diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
index c23f3b9..84f7a88 100644
--- a/arch/x86/boot/string.c
+++ b/arch/x86/boot/string.c
@@ -88,14 +88,6 @@ size_t strnlen(const char *s, size_t maxlen)
 	return (es - s);
 }
 
-unsigned int atou(const char *s)
-{
-	unsigned int i = 0;
-	while (isdigit(*s))
-		i = i * 10 + (*s++ - '0');
-	return i;
-}
-
 /* Works only for digits and letters, but small and fast */
 #define TOLOWER(x) ((x) | 0x20)
 
diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
index e5d2c6b..a5b05eb 100644
--- a/arch/x86/boot/string.h
+++ b/arch/x86/boot/string.h
@@ -24,7 +24,6 @@ extern size_t strlen(const char *s);
 extern char *strstr(const char *s1, const char *s2);
 extern char *strchr(const char *s, int c);
 extern size_t strnlen(const char *s, size_t maxlen);
-extern unsigned int atou(const char *s);
 extern unsigned long long simple_strtoull(const char *cp, char **endp,
 					  unsigned int base);
 long simple_strtol(const char *cp, char **endp, unsigned int base);