[PATCH v2 0/3] rtc: isl12022: Add alarm support

Esben Haabendal posted 3 patches 2 months, 2 weeks ago
drivers/rtc/rtc-isl12022.c | 269 ++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 253 insertions(+), 16 deletions(-)
[PATCH v2 0/3] rtc: isl12022: Add alarm support
Posted by Esben Haabendal 2 months, 2 weeks ago
Extend the rtc-isl12022 driver with alarm IRQ support.

Signed-off-by: Esben Haabendal <esben@geanix.com>
---
Changes in v2:
- Various coding style changes.
- Remove const keyword from auto variable declaration.
- Use u8 type instead of uint8_t.
- Fixed bad return value in isl12022_rtc_read_alarm() error handling.
- Change variable type from int to unsigned int for variable given to
  regmap_read().
- Drop unneeded variable initialization (ret) in
  isl12022_rtc_set_alarm().
- Extend use of DWA0 variable to avoid false alarm trigger also when
  disabling alarm.
- Clarify the use of !! operator in isl12022_rtc_alarm_irq_enable().
- Change isl12022_setup_irq() prototype to avoid the need for storing
  struct i2c_client in struct isl12022.
- Use dev_err_probe() where appropriate.
- Change dev_err messages reporting problems with register access into
  dev_dbg.
- Renamed ISL12022_ALARM_SECTION to ISL12022_ALARM for better use of
  horizontal space.
- Leave FOBATB bit untouched.
- Link to v1: https://lore.kernel.org/r/20240910-rtc-isl12022-alarm-irq-v1-0-d875cedc997f@geanix.com

---
Esben Haabendal (3):
      rtc: isl12022: Prepare for extending rtc device drvdata
      rtc: isl12022: Add alarm support
      rtc: isl12022: Replace uint8_t types with u8

 drivers/rtc/rtc-isl12022.c | 269 ++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 253 insertions(+), 16 deletions(-)
---
base-commit: da3ea35007d0af457a0afc87e84fddaebc4e0b63
change-id: 20240910-rtc-isl12022-alarm-irq-197ef2350c3e

Best regards,
-- 
Esben Haabendal <esben@geanix.com>
Re: [PATCH v2 0/3] rtc: isl12022: Add alarm support
Posted by Alexandre Belloni 2 weeks, 4 days ago
On Fri, 13 Sep 2024 12:29:11 +0200, Esben Haabendal wrote:
> Extend the rtc-isl12022 driver with alarm IRQ support.
> 
> 

Applied, thanks!

[1/3] rtc: isl12022: Prepare for extending rtc device drvdata
      https://git.kernel.org/abelloni/c/d4a6161f242b
[2/3] rtc: isl12022: Add alarm support
      https://git.kernel.org/abelloni/c/c62d658e5253
[3/3] rtc: isl12022: Replace uint8_t types with u8
      https://git.kernel.org/abelloni/c/5a36826a5909

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com