[PATCH v2 0/5] drm: Use IRQF_NO_AUTOEN flag in request_irq()

Jinjie Ruan posted 5 patches 2 months, 2 weeks ago
drivers/gpu/drm/imx/dcss/dcss-crtc.c   | 6 ++----
drivers/gpu/drm/imx/dcss/dcss-dtg.c    | 4 +---
drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c | 6 ++----
drivers/gpu/drm/msm/adreno/a6xx_gmu.c  | 4 +---
drivers/gpu/drm/tegra/dpaux.c          | 4 +---
5 files changed, 7 insertions(+), 17 deletions(-)
[PATCH v2 0/5] drm: Use IRQF_NO_AUTOEN flag in request_irq()
Posted by Jinjie Ruan 2 months, 2 weeks ago
As commit cbe16f35bee6 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
said, reqeust_irq() and then disable_irq() is unsafe. In the small time gap
between request_irq() and disable_irq(), interrupts can still come.

IRQF_NO_AUTOEN flag can be used by drivers to request_irq(). It prevents
the automatic enabling of the requested interrupt in the same
safe way. With that the usage can be simplified and corrected.

Compile-tested only.

Changes in v2:
- Correct the commit subject.
- Add reviewed-by.

Jinjie Ruan (5):
  drm/imx: Use IRQF_NO_AUTOEN flag in request_irq()
  drm/imx/dcss: Use IRQF_NO_AUTOEN flag in request_irq()
  drm/imx/ipuv3: Use IRQF_NO_AUTOEN flag in request_irq()
  drm/tegra: dpaux: Use IRQF_NO_AUTOEN flag in request_irq()
  drm/msm/adreno: Use IRQF_NO_AUTOEN flag in request_irq()

 drivers/gpu/drm/imx/dcss/dcss-crtc.c   | 6 ++----
 drivers/gpu/drm/imx/dcss/dcss-dtg.c    | 4 +---
 drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c | 6 ++----
 drivers/gpu/drm/msm/adreno/a6xx_gmu.c  | 4 +---
 drivers/gpu/drm/tegra/dpaux.c          | 4 +---
 5 files changed, 7 insertions(+), 17 deletions(-)

-- 
2.34.1
Re: (subset) [PATCH v2 0/5] drm: Use IRQF_NO_AUTOEN flag in request_irq()
Posted by Dmitry Baryshkov 2 months, 1 week ago
On Thu, 12 Sep 2024 16:30:15 +0800, Jinjie Ruan wrote:
> As commit cbe16f35bee6 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
> said, reqeust_irq() and then disable_irq() is unsafe. In the small time gap
> between request_irq() and disable_irq(), interrupts can still come.
> 
> IRQF_NO_AUTOEN flag can be used by drivers to request_irq(). It prevents
> the automatic enabling of the requested interrupt in the same
> safe way. With that the usage can be simplified and corrected.
> 
> [...]

Applied to drm-misc-next, thanks!

[1/5] drm/imx: Use IRQF_NO_AUTOEN flag in request_irq()
      commit: 1af01e14db7e0b45ae502d822776a58c86688763
[2/5] drm/imx/dcss: Use IRQF_NO_AUTOEN flag in request_irq()
      commit: 4380f8624b8bff3637476726351ed7bb8850188a
[3/5] drm/imx/ipuv3: Use IRQF_NO_AUTOEN flag in request_irq()
      commit: 40004709a3d3b07041a473a163ca911ef04ab8bd

Best regards,
-- 
With best wishes
Dmitry