[v2] platform/x86/amd: pmf: Add quirk for TUF Gaming A14

[PATCH v2] platform/x86/amd: pmf: Add quirk for TUF Gaming A14

Posted by aln8 2 months, 2 weeks ago

The ASUS TUF Gaming A14 has the same issue as the ROG Zephyrus G14
where it advertises SPS support but doesn't use it.

Signed-off-by: aln8 <aln8un@gmail.com>
---
v1 -> v2: Change to FA401W so full series models will get the fix.
---
 drivers/platform/x86/amd/pmf/pmf-quirks.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/platform/x86/amd/pmf/pmf-quirks.c b/drivers/platform/x86/amd/pmf/pmf-quirks.c
index 48870ca52..7cde5733b 100644
--- a/drivers/platform/x86/amd/pmf/pmf-quirks.c
+++ b/drivers/platform/x86/amd/pmf/pmf-quirks.c
@@ -37,6 +37,14 @@ static const struct dmi_system_id fwbug_list[] = {
 		},
 		.driver_data = &quirk_no_sps_bug,
 	},
+	{
+		.ident = "ASUS TUF Gaming A14",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "FA401W"),
+		},
+		.driver_data = &quirk_no_sps_bug,
+	},
 	{}
 };
 
-- 
2.46.0

Re: [PATCH v2] platform/x86/amd: pmf: Add quirk for TUF Gaming A14

Posted by Hans de Goede 2 months, 2 weeks ago

Hi,

On 9/12/24 9:36 AM, aln8 wrote:
> The ASUS TUF Gaming A14 has the same issue as the ROG Zephyrus G14
> where it advertises SPS support but doesn't use it.
> 
> Signed-off-by: aln8 <aln8un@gmail.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans




> ---
> v1 -> v2: Change to FA401W so full series models will get the fix.
> ---
>  drivers/platform/x86/amd/pmf/pmf-quirks.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/pmf/pmf-quirks.c b/drivers/platform/x86/amd/pmf/pmf-quirks.c
> index 48870ca52..7cde5733b 100644
> --- a/drivers/platform/x86/amd/pmf/pmf-quirks.c
> +++ b/drivers/platform/x86/amd/pmf/pmf-quirks.c
> @@ -37,6 +37,14 @@ static const struct dmi_system_id fwbug_list[] = {
>  		},
>  		.driver_data = &quirk_no_sps_bug,
>  	},
> +	{
> +		.ident = "ASUS TUF Gaming A14",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "FA401W"),
> +		},
> +		.driver_data = &quirk_no_sps_bug,
> +	},
>  	{}
>  };
>

Re: [PATCH v2] platform/x86/amd: pmf: Add quirk for TUF Gaming A14

Posted by Shyam Sundar S K 2 months, 2 weeks ago


On 9/12/2024 13:06, aln8 wrote:
> The ASUS TUF Gaming A14 has the same issue as the ROG Zephyrus G14
> where it advertises SPS support but doesn't use it.
> 
> Signed-off-by: aln8 <aln8un@gmail.com>

Thank you for the patch. Looks good to me.

Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

> ---
> v1 -> v2: Change to FA401W so full series models will get the fix.
> ---
>  drivers/platform/x86/amd/pmf/pmf-quirks.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/pmf/pmf-quirks.c b/drivers/platform/x86/amd/pmf/pmf-quirks.c
> index 48870ca52..7cde5733b 100644
> --- a/drivers/platform/x86/amd/pmf/pmf-quirks.c
> +++ b/drivers/platform/x86/amd/pmf/pmf-quirks.c
> @@ -37,6 +37,14 @@ static const struct dmi_system_id fwbug_list[] = {
>  		},
>  		.driver_data = &quirk_no_sps_bug,
>  	},
> +	{
> +		.ident = "ASUS TUF Gaming A14",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "FA401W"),
> +		},
> +		.driver_data = &quirk_no_sps_bug,
> +	},
>  	{}
>  };
>