On 12/09/2024 20:24, Arturs Artamonovs via B4 Relay wrote:
> From: Arturs Artamonovs <arturs.artamonovs@analog.com>
>
> add SoC ADSP-SC5xx
>
> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
> Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com>
> Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
> Co-developed-by: Greg Malysa <greg.malysa@timesys.com>
> Signed-off-by: Greg Malysa <greg.malysa@timesys.com>
> ---
> .../devicetree/bindings/arm/analog/adi,sc5xx.yaml | 24 ++++++++++++++++++++++
There is no arm64 prefix above. Fix subject.
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 1 file changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/analog/adi,sc5xx.yaml b/Documentation/devicetree/bindings/arm/analog/adi,sc5xx.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..fc37242b32b9ca9b82fd5b3e0288642e8c4fd9f0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/analog/adi,sc5xx.yaml
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/analog/adi,sc5xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices SC59X 64-Bit ARM-based Processor Families
> +
> +maintainers:
> + - Arturs Artamonovs <arturs.artamonovs@analog.com>
> + - Utsav Agarwal <Utsav.Agarwal@analog.com>
> +
> +properties:
> + $nodename:
> + const: '/'
> + compatible:
> + description: SC59X 64-Bit Boards
> + items:
> + - enum:
> + - adi,sc598-som-ezkit # Analog Devices SC598 EZKit
> + - adi,sc598-som-ezlite # Analog Devices SC598 EZLite
> + - const: adi,sc59x-64
sc59x is incorrect. Enum above says sc598. Define what is the SoC here.
You cannot have compatible for families.
> +
> +additionalProperties: true
>
Best regards,
Krzysztof