[v1] f2fs: forcibly migrate to secure space for zoned device file pinning

[PATCH] f2fs: forcibly migrate to secure space for zoned device file pinning

Posted by Daeho Jeong 1 year, 4 months ago

From: Daeho Jeong <daehojeong@google.com>

We need to migrate data blocks even though it is full to secure space
for zoned device file pinning.

Signed-off-by: Daeho Jeong <daehojeong@google.com>
Fixes: 9703d69d9d15 ("f2fs: support file pinning for zoned devices")
---
 fs/f2fs/gc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 724bbcb447d3..aaae13493a70 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -2010,8 +2010,7 @@ int f2fs_gc_range(struct f2fs_sb_info *sbi,
 			.iroot = RADIX_TREE_INIT(gc_list.iroot, GFP_NOFS),
 		};
 
-		do_garbage_collect(sbi, segno, &gc_list, FG_GC,
-						dry_run_sections == 0);
+		do_garbage_collect(sbi, segno, &gc_list, FG_GC, true);
 		put_gc_inode(&gc_list);
 
 		if (!dry_run && get_valid_blocks(sbi, segno, true))
-- 
2.46.0.598.g6f2099f65c-goog

Re: [PATCH] f2fs: forcibly migrate to secure space for zoned device file pinning

Posted by Jaegeuk Kim 1 year, 4 months ago

On 09/11, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
> 
> We need to migrate data blocks even though it is full to secure space
> for zoned device file pinning.
> 
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> Fixes: 9703d69d9d15 ("f2fs: support file pinning for zoned devices")
> ---
>  fs/f2fs/gc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 724bbcb447d3..aaae13493a70 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -2010,8 +2010,7 @@ int f2fs_gc_range(struct f2fs_sb_info *sbi,
>  			.iroot = RADIX_TREE_INIT(gc_list.iroot, GFP_NOFS),
>  		};
>  
> -		do_garbage_collect(sbi, segno, &gc_list, FG_GC,
> -						dry_run_sections == 0);
> +		do_garbage_collect(sbi, segno, &gc_list, FG_GC, true);

Do you mean this, right?

do_garbage_collect(sbi, segno, &gc_list, FG_GC, true, false);

>  		put_gc_inode(&gc_list);
>  
>  		if (!dry_run && get_valid_blocks(sbi, segno, true))
> -- 
> 2.46.0.598.g6f2099f65c-goog
>

Re: [PATCH] f2fs: forcibly migrate to secure space for zoned device file pinning

Posted by Daeho Jeong 1 year, 4 months ago

On Thu, Sep 12, 2024 at 7:45 AM Jaegeuk Kim <jaegeuk@kernel.org> wrote:
>
> On 09/11, Daeho Jeong wrote:
> > From: Daeho Jeong <daehojeong@google.com>
> >
> > We need to migrate data blocks even though it is full to secure space
> > for zoned device file pinning.
> >
> > Signed-off-by: Daeho Jeong <daehojeong@google.com>
> > Fixes: 9703d69d9d15 ("f2fs: support file pinning for zoned devices")
> > ---
> >  fs/f2fs/gc.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> > index 724bbcb447d3..aaae13493a70 100644
> > --- a/fs/f2fs/gc.c
> > +++ b/fs/f2fs/gc.c
> > @@ -2010,8 +2010,7 @@ int f2fs_gc_range(struct f2fs_sb_info *sbi,
> >                       .iroot = RADIX_TREE_INIT(gc_list.iroot, GFP_NOFS),
> >               };
> >
> > -             do_garbage_collect(sbi, segno, &gc_list, FG_GC,
> > -                                             dry_run_sections == 0);
> > +             do_garbage_collect(sbi, segno, &gc_list, FG_GC, true);
>
> Do you mean this, right?
>
> do_garbage_collect(sbi, segno, &gc_list, FG_GC, true, false);

Oh, after ZUFS GC patches, we have six parameters on that. You're right.

static int do_garbage_collect(struct f2fs_sb_info *sbi,
                                unsigned int start_segno,
                                struct gc_inode_list *gc_list, int gc_type,
                                bool force_migrate)
>
> >               put_gc_inode(&gc_list);
> >
> >               if (!dry_run && get_valid_blocks(sbi, segno, true))
> > --
> > 2.46.0.598.g6f2099f65c-goog
> >