[PATCH 0/2] X1E001DE Snapdragon Devkit for Windows

Sibi Sankar posted 2 patches 2 months, 2 weeks ago
There is a newer version of this series
.../devicetree/bindings/arm/qcom.yaml         |   6 +
arch/arm64/boot/dts/qcom/Makefile             |   1 +
arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 813 ++++++++++++++++++
3 files changed, 820 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
[PATCH 0/2] X1E001DE Snapdragon Devkit for Windows
Posted by Sibi Sankar 2 months, 2 weeks ago
Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
is the speed binned variant of X1E80100 that supports turbo boost up to
4.3 Ghz. The initial support includes the following:

-DSPs
-Ethernet (RTL8125BG) over the pcie 5 instance.
-NVme
-Wifi
-USB-C ports

Link: https://www.qualcomm.com/news/releases/2024/05/qualcomm-accelerates-development-for-copilot--pcs-with-snapdrago

Sibi Sankar (2):
  dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
  arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows

 .../devicetree/bindings/arm/qcom.yaml         |   6 +
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 813 ++++++++++++++++++
 3 files changed, 820 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts

-- 
2.34.1
Re: [PATCH 0/2] X1E001DE Snapdragon Devkit for Windows
Posted by Sibi Sankar 1 month, 1 week ago

On 9/11/24 13:03, Sibi Sankar wrote:
> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
> is the speed binned variant of X1E80100 that supports turbo boost up to
> 4.3 Ghz. The initial support includes the following:
> 
> -DSPs
> -Ethernet (RTL8125BG) over the pcie 5 instance.
> -NVme
> -Wifi
> -USB-C ports
> 

Hi All,

With the X1E Devkit cancelled and with no firmware updates promised for
it perpetually, please chime in and let me know if you still want to get
this series and rest (external-dp, usb-A ports, sd card slot and 3.5 mm
Jack) merged and have it supported upstream for the folks who already
received it!

-Sibi

> Link: https://www.qualcomm.com/news/releases/2024/05/qualcomm-accelerates-development-for-copilot--pcs-with-snapdrago
> 
> Sibi Sankar (2):
>    dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
>    arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
> 
>   .../devicetree/bindings/arm/qcom.yaml         |   6 +
>   arch/arm64/boot/dts/qcom/Makefile             |   1 +
>   arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 813 ++++++++++++++++++
>   3 files changed, 820 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
>
Re: [PATCH 0/2] X1E001DE Snapdragon Devkit for Windows
Posted by Marc Zyngier 1 month ago
Hi Sibi,

On Wed, 23 Oct 2024 12:05:35 +0100,
Sibi Sankar <quic_sibis@quicinc.com> wrote:
> 
> 
> 
> On 9/11/24 13:03, Sibi Sankar wrote:
> > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
> > is the speed binned variant of X1E80100 that supports turbo boost up to
> > 4.3 Ghz. The initial support includes the following:
> > 
> > -DSPs
> > -Ethernet (RTL8125BG) over the pcie 5 instance.
> > -NVme
> > -Wifi
> > -USB-C ports
> > 
> 
> Hi All,
> 
> With the X1E Devkit cancelled and with no firmware updates promised for
> it perpetually, please chime in and let me know if you still want to get
> this series and rest (external-dp, usb-A ports, sd card slot and 3.5 mm
> Jack) merged and have it supported upstream for the folks who already
> received it!

I have one of these machines in my zoo, and would definitely want to
see it fully supported upstream, even if QC never updates it again.
The feature set of this box is rare enough that it makes it a very
interesting platform.

So far, everything seems to be working just fine (except for the
missing features you have mentioned).

The only change I made was to enable the ITS for pcie5, which was
routed via the PCIe MSI widget instead. But that's a SoC dtsi issue
for which I'll post a patch separately.

Thanks again for your effort, and I'm looking forward to seeing this
box fully supported upstream despite its very short shelf life! ;-)

	M.

-- 
Without deviation from the norm, progress is not possible.
Re: [PATCH 0/2] X1E001DE Snapdragon Devkit for Windows
Posted by Johan Hovold 1 month ago
On Thu, Oct 24, 2024 at 05:02:29PM +0100, Marc Zyngier wrote:

> The only change I made was to enable the ITS for pcie5, which was
> routed via the PCIe MSI widget instead. But that's a SoC dtsi issue
> for which I'll post a patch separately.

That's done on purpose since the boot firmware is not setting things up
so that we can use the ITS with PCIe5 (or PCIe3) when running in EL1
currently.

Johan
Re: [PATCH 0/2] X1E001DE Snapdragon Devkit for Windows
Posted by Marc Zyngier 1 month ago
On Thu, 24 Oct 2024 17:15:28 +0100,
Johan Hovold <johan@kernel.org> wrote:
> 
> On Thu, Oct 24, 2024 at 05:02:29PM +0100, Marc Zyngier wrote:
> 
> > The only change I made was to enable the ITS for pcie5, which was
> > routed via the PCIe MSI widget instead. But that's a SoC dtsi issue
> > for which I'll post a patch separately.
> 
> That's done on purpose since the boot firmware is not setting things up
> so that we can use the ITS with PCIe5 (or PCIe3) when running in EL1
> currently.

Really? I guess they don't install a mapping for the ITS translation
register in the SMMUv3? That's rather sad.

I guess I will keep this as part of my "EL2-special" patch set then.
Feel free to ignore the patch I have just sent.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.
Re: [PATCH 0/2] X1E001DE Snapdragon Devkit for Windows
Posted by neil.armstrong@linaro.org 1 month ago
Hi,

On 23/10/2024 13:05, Sibi Sankar wrote:
> 
> 
> On 9/11/24 13:03, Sibi Sankar wrote:
>> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
>> is the speed binned variant of X1E80100 that supports turbo boost up to
>> 4.3 Ghz. The initial support includes the following:
>>
>> -DSPs
>> -Ethernet (RTL8125BG) over the pcie 5 instance.
>> -NVme
>> -Wifi
>> -USB-C ports
>>
> 
> Hi All,
> 
> With the X1E Devkit cancelled and with no firmware updates promised for
> it perpetually, please chime in and let me know if you still want to get
> this series and rest (external-dp, usb-A ports, sd card slot and 3.5 mm
> Jack) merged and have it supported upstream for the folks who already
> received it!

As there's some people owning this kit in the wild, yes please make sure the
current patchset goes into mainline and I assume the community will add the
missing bits in the future.

Thanks,
Neil

> 
> -Sibi
> 
>> Link: https://www.qualcomm.com/news/releases/2024/05/qualcomm-accelerates-development-for-copilot--pcs-with-snapdrago
>>
>> Sibi Sankar (2):
>>    dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
>>    arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
>>
>>   .../devicetree/bindings/arm/qcom.yaml         |   6 +
>>   arch/arm64/boot/dts/qcom/Makefile             |   1 +
>>   arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 813 ++++++++++++++++++
>>   3 files changed, 820 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
>>
> 

Re: [PATCH 0/2] X1E001DE Snapdragon Devkit for Windows
Posted by Jens Glathe 1 month ago
On 23.10.24 13:05, Sibi Sankar wrote:
>
>
> On 9/11/24 13:03, Sibi Sankar wrote:
>> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
>> is the speed binned variant of X1E80100 that supports turbo boost up to
>> 4.3 Ghz. The initial support includes the following:
>>
>> -DSPs
>> -Ethernet (RTL8125BG) over the pcie 5 instance.
>> -NVme
>> -Wifi
>> -USB-C ports
>>
>
> Hi All,
>
> With the X1E Devkit cancelled and with no firmware updates promised for
> it perpetually, please chime in and let me know if you still want to get
> this series and rest (external-dp, usb-A ports, sd card slot and 3.5 mm
> Jack) merged and have it supported upstream for the folks who already
> received it!
>
> -Sibi
>
>> Link:
>> https://www.qualcomm.com/news/releases/2024/05/qualcomm-accelerates-development-for-copilot--pcs-with-snapdrago
>>
>> Sibi Sankar (2):
>>    dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
>>    arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
>>
>>   .../devicetree/bindings/arm/qcom.yaml         |   6 +
>>   arch/arm64/boot/dts/qcom/Makefile             |   1 +
>>   arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 813 ++++++++++++++++++
>>   3 files changed, 820 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
>>
>
Hi there,

as one of the few owners of this box I am very interested in getting an
as complete dt as possible. It may be unsupported (who cares), but it is
quite useful hardware. So, yes please! I already have it up with the
published patch and its doing useful stuff.

- Jens
Re: [PATCH 0/2] X1E001DE Snapdragon Devkit for Windows
Posted by Jens Glathe 1 month ago
Hi there,

as one of the few owners of this box I am very interested in getting an
as complete dt as possible. It may be unsupported (who cares), but it is
quite useful hardware. So, yes please! I already have it up with the
published patch and its doing useful stuff.

- Jens

On 23.10.24 13:05, Sibi Sankar wrote:
>
>
> On 9/11/24 13:03, Sibi Sankar wrote:
>> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
>> is the speed binned variant of X1E80100 that supports turbo boost up to
>> 4.3 Ghz. The initial support includes the following:
>>
>> -DSPs
>> -Ethernet (RTL8125BG) over the pcie 5 instance.
>> -NVme
>> -Wifi
>> -USB-C ports
>>
>
> Hi All,
>
> With the X1E Devkit cancelled and with no firmware updates promised for
> it perpetually, please chime in and let me know if you still want to get
> this series and rest (external-dp, usb-A ports, sd card slot and 3.5 mm
> Jack) merged and have it supported upstream for the folks who already
> received it!
>
> -Sibi
>
>> Link:
>> https://www.qualcomm.com/news/releases/2024/05/qualcomm-accelerates-development-for-copilot--pcs-with-snapdrago
>>
>> Sibi Sankar (2):
>>    dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
>>    arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
>>
>>   .../devicetree/bindings/arm/qcom.yaml         |   6 +
>>   arch/arm64/boot/dts/qcom/Makefile             |   1 +
>>   arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 813 ++++++++++++++++++
>>   3 files changed, 820 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
>>
>
Re: [PATCH 0/2] X1E001DE Snapdragon Devkit for Windows
Posted by Rob Clark 1 month, 1 week ago
On Wed, Oct 23, 2024 at 4:07 AM Sibi Sankar <quic_sibis@quicinc.com> wrote:
>
>
>
> On 9/11/24 13:03, Sibi Sankar wrote:
> > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE
> > is the speed binned variant of X1E80100 that supports turbo boost up to
> > 4.3 Ghz. The initial support includes the following:
> >
> > -DSPs
> > -Ethernet (RTL8125BG) over the pcie 5 instance.
> > -NVme
> > -Wifi
> > -USB-C ports
> >
>
> Hi All,
>
> With the X1E Devkit cancelled and with no firmware updates promised for
> it perpetually, please chime in and let me know if you still want to get
> this series and rest (external-dp, usb-A ports, sd card slot and 3.5 mm
> Jack) merged and have it supported upstream for the folks who already
> received it!

(a) would the firmware update situation have been _that_ much better
if it wasn't cancelled?  And (b) we do have dts upstream for other
canceled boards.

My $0.02 is that it is still useful

BR,
-R

> -Sibi
>
> > Link: https://www.qualcomm.com/news/releases/2024/05/qualcomm-accelerates-development-for-copilot--pcs-with-snapdrago
> >
> > Sibi Sankar (2):
> >    dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows
> >    arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows
> >
> >   .../devicetree/bindings/arm/qcom.yaml         |   6 +
> >   arch/arm64/boot/dts/qcom/Makefile             |   1 +
> >   arch/arm64/boot/dts/qcom/x1e001de-devkit.dts  | 813 ++++++++++++++++++
> >   3 files changed, 820 insertions(+)
> >   create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> >
>