[v1] add NXP RTC driver support for S32G2/S32G3 SoCs

[PATCH 4/4] MAINTAINERS: add MAINTAINER for S32G2/S32G3 RTC driver

Posted by Ciprian Costea 2 months, 2 weeks ago

From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>

Now that a RTC driver was added for S32G2/S32G3 SoC, update
the mainainters list for it.

Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index f328373463b0..a6d91101ec43 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2686,11 +2686,13 @@ ARM/NXP S32G ARCHITECTURE
 R:	Chester Lin <chester62515@gmail.com>
 R:	Matthias Brugger <mbrugger@suse.com>
 R:	Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>
+R:	Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
 L:	NXP S32 Linux Team <s32@nxp.com>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 F:	arch/arm64/boot/dts/freescale/s32g*.dts*
 F:	drivers/pinctrl/nxp/
+F:	drivers/rtc/rtc-s32g.c
 
 ARM/Orion SoC/Technologic Systems TS-78xx platform support
 M:	Alexander Clouter <alex@digriz.org.uk>
-- 
2.45.2

Re: [PATCH 4/4] MAINTAINERS: add MAINTAINER for S32G2/S32G3 RTC driver

Posted by Krzysztof Kozlowski 2 months, 1 week ago

On 11/09/2024 09:00, Ciprian Costea wrote:
> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
> 
> Now that a RTC driver was added for S32G2/S32G3 SoC, update
> the mainainters list for it.

Why? You don't do that alone. You add yourself for entire platform!

> 
> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f328373463b0..a6d91101ec43 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2686,11 +2686,13 @@ ARM/NXP S32G ARCHITECTURE
>  R:	Chester Lin <chester62515@gmail.com>
>  R:	Matthias Brugger <mbrugger@suse.com>
>  R:	Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>

If you are touching someone's maintainer entry, at least you could do is
to CC them.

And how many reviewers do you want to have in that platform? Are all
entries real or some are stale?

Best regards,
Krzysztof

Re: [PATCH 4/4] MAINTAINERS: add MAINTAINER for S32G2/S32G3 RTC driver

Posted by Ciprian Marian Costea 2 months, 1 week ago

On 9/17/2024 8:37 PM, Krzysztof Kozlowski wrote:
> On 11/09/2024 09:00, Ciprian Costea wrote:
>> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>>
>> Now that a RTC driver was added for S32G2/S32G3 SoC, update
>> the mainainters list for it.
> 
> Why? You don't do that alone. You add yourself for entire platform!
> 
>>
>> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>> ---
>>   MAINTAINERS | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index f328373463b0..a6d91101ec43 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2686,11 +2686,13 @@ ARM/NXP S32G ARCHITECTURE
>>   R:	Chester Lin <chester62515@gmail.com>
>>   R:	Matthias Brugger <mbrugger@suse.com>
>>   R:	Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>
> 
> If you are touching someone's maintainer entry, at least you could do is
> to CC them.
> 
> And how many reviewers do you want to have in that platform? Are all
> entries real or some are stale?
> 
> Best regards,
> Krzysztof
> 

Hello Krzysztof,

My intention was to add myself as a reviewer for the S32G Architecture 
and not as a maintainer.

I plan to send more patches targeting this architecture and I would like 
to review any other changes to them in the future.

On the other hand I understand your point, already having a list of 
reviewers. If its unacceptable, I can only add myself as a maintainer 
for the S32G RTC driver, in V2 of this patchset.

Best Regards,
Ciprian

Re: [PATCH 4/4] MAINTAINERS: add MAINTAINER for S32G2/S32G3 RTC driver

Posted by Krzysztof Kozlowski 2 months, 1 week ago

On 18/09/2024 10:13, Ciprian Marian Costea wrote:
> On 9/17/2024 8:37 PM, Krzysztof Kozlowski wrote:
>> On 11/09/2024 09:00, Ciprian Costea wrote:
>>> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>>>
>>> Now that a RTC driver was added for S32G2/S32G3 SoC, update
>>> the mainainters list for it.
>>
>> Why? You don't do that alone. You add yourself for entire platform!
>>
>>>
>>> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>>> ---
>>>   MAINTAINERS | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index f328373463b0..a6d91101ec43 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -2686,11 +2686,13 @@ ARM/NXP S32G ARCHITECTURE
>>>   R:	Chester Lin <chester62515@gmail.com>
>>>   R:	Matthias Brugger <mbrugger@suse.com>
>>>   R:	Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>
>>
>> If you are touching someone's maintainer entry, at least you could do is
>> to CC them.
>>
>> And how many reviewers do you want to have in that platform? Are all
>> entries real or some are stale?
>>
>> Best regards,
>> Krzysztof
>>
> 
> Hello Krzysztof,
> 
> My intention was to add myself as a reviewer for the S32G Architecture 
> and not as a maintainer.
> 
> I plan to send more patches targeting this architecture and I would like 
> to review any other changes to them in the future.
> 
> On the other hand I understand your point, already having a list of 
> reviewers. If its unacceptable, I can only add myself as a maintainer 
> for the S32G RTC driver, in V2 of this patchset.
> 

Folks:
1. It is okay to have more maintainers or reviewers
2. Document the express, be explicit in commit msg, provide some reasoning
3. Be sure BEFORE you talked with existing maintainers and they are
onboard, unless they are not responsive
4. Explain why the list of three has to grow to list of 5 (or you did
not align it with your colleagues, either). Yes, I see your other emails
and it is very confusing that two of such events happen independently.
It is not community task to coordinate your team activities...

Best regards,
Krzysztof