1. Patchew
  2. linux
  3. View series

[PATCH v2] dt-bindings: phy: Add QMP UFS PHY comptible for QCS8300

Jingyi Wang posted 1 patch 2 months, 2 weeks ago 
.../bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml    | 46 ++++++++++++----------
1 file changed, 26 insertions(+), 20 deletions(-)
[PATCH v2] dt-bindings: phy: Add QMP UFS PHY comptible for QCS8300
Posted by Jingyi Wang 2 months, 2 weeks ago 
From: Xin Liu <quic_liuxin@quicinc.com>

Document the QMP UFS PHY compatible for Qualcomm QCS8300 to support
physical layer functionality for UFS found on the SoC. Use fallback to
indicate the compatibility of the QMP UFS PHY on the QCS8300 with that
on the SA8775P.

Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
---
Changes in v2:
- decoupled from the original series.
- Use fallback to indicate compatibility with SA8775P.
- typo fixup
- Link to v1: https://lore.kernel.org/r/20240904-qcs8300_initial_dtsi-v1-0-d0ea9afdc007@quicinc.com
---
 .../bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml    | 46 ++++++++++++----------
 1 file changed, 26 insertions(+), 20 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
index f9cfbd0b2de6..626a2039e177 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
@@ -15,26 +15,31 @@ description:
 
 properties:
   compatible:
-    enum:
-      - qcom,msm8996-qmp-ufs-phy
-      - qcom,msm8998-qmp-ufs-phy
-      - qcom,sa8775p-qmp-ufs-phy
-      - qcom,sc7180-qmp-ufs-phy
-      - qcom,sc7280-qmp-ufs-phy
-      - qcom,sc8180x-qmp-ufs-phy
-      - qcom,sc8280xp-qmp-ufs-phy
-      - qcom,sdm845-qmp-ufs-phy
-      - qcom,sm6115-qmp-ufs-phy
-      - qcom,sm6125-qmp-ufs-phy
-      - qcom,sm6350-qmp-ufs-phy
-      - qcom,sm7150-qmp-ufs-phy
-      - qcom,sm8150-qmp-ufs-phy
-      - qcom,sm8250-qmp-ufs-phy
-      - qcom,sm8350-qmp-ufs-phy
-      - qcom,sm8450-qmp-ufs-phy
-      - qcom,sm8475-qmp-ufs-phy
-      - qcom,sm8550-qmp-ufs-phy
-      - qcom,sm8650-qmp-ufs-phy
+    oneOf:
+      - items:
+          - enum:
+              - qcom,qcs8300-qmp-ufs-phy
+          - const: qcom,sa8775p-qmp-ufs-phy
+      - enum:
+          - qcom,msm8996-qmp-ufs-phy
+          - qcom,msm8998-qmp-ufs-phy
+          - qcom,sa8775p-qmp-ufs-phy
+          - qcom,sc7180-qmp-ufs-phy
+          - qcom,sc7280-qmp-ufs-phy
+          - qcom,sc8180x-qmp-ufs-phy
+          - qcom,sc8280xp-qmp-ufs-phy
+          - qcom,sdm845-qmp-ufs-phy
+          - qcom,sm6115-qmp-ufs-phy
+          - qcom,sm6125-qmp-ufs-phy
+          - qcom,sm6350-qmp-ufs-phy
+          - qcom,sm7150-qmp-ufs-phy
+          - qcom,sm8150-qmp-ufs-phy
+          - qcom,sm8250-qmp-ufs-phy
+          - qcom,sm8350-qmp-ufs-phy
+          - qcom,sm8450-qmp-ufs-phy
+          - qcom,sm8475-qmp-ufs-phy
+          - qcom,sm8550-qmp-ufs-phy
+          - qcom,sm8650-qmp-ufs-phy
 
   reg:
     maxItems: 1
@@ -85,6 +90,7 @@ allOf:
           contains:
             enum:
               - qcom,msm8998-qmp-ufs-phy
+              - qcom,qcs8300-qmp-ufs-phy
               - qcom,sa8775p-qmp-ufs-phy
               - qcom,sc7180-qmp-ufs-phy
               - qcom,sc7280-qmp-ufs-phy

---
base-commit: 100cc857359b5d731407d1038f7e76cd0e871d94
change-id: 20240911-qcs8300_ufs_phy_binding-84640e3e7bb7

Best regards,
-- 
Jingyi Wang <quic_jingyw@quicinc.com>
Re: [PATCH v2] dt-bindings: phy: Add QMP UFS PHY comptible for QCS8300
Posted by Krzysztof Kozlowski 2 months, 2 weeks ago 
On Wed, Sep 11, 2024 at 02:56:16PM +0800, Jingyi Wang wrote:
> From: Xin Liu <quic_liuxin@quicinc.com>
> 
> Document the QMP UFS PHY compatible for Qualcomm QCS8300 to support
> physical layer functionality for UFS found on the SoC. Use fallback to
> indicate the compatibility of the QMP UFS PHY on the QCS8300 with that
> on the SA8775P.
> 
> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
> ---
> Changes in v2:
> - decoupled from the original series.
> - Use fallback to indicate compatibility with SA8775P.
> - typo fixup
> - Link to v1: https://lore.kernel.org/r/20240904-qcs8300_initial_dtsi-v1-0-d0ea9afdc007@quicinc.com
> ---
>  .../bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml    | 46 ++++++++++++----------
>  1 file changed, 26 insertions(+), 20 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> index f9cfbd0b2de6..626a2039e177 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> @@ -15,26 +15,31 @@ description:
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,msm8996-qmp-ufs-phy
> -      - qcom,msm8998-qmp-ufs-phy
> -      - qcom,sa8775p-qmp-ufs-phy
> -      - qcom,sc7180-qmp-ufs-phy
> -      - qcom,sc7280-qmp-ufs-phy
> -      - qcom,sc8180x-qmp-ufs-phy
> -      - qcom,sc8280xp-qmp-ufs-phy
> -      - qcom,sdm845-qmp-ufs-phy
> -      - qcom,sm6115-qmp-ufs-phy
> -      - qcom,sm6125-qmp-ufs-phy
> -      - qcom,sm6350-qmp-ufs-phy
> -      - qcom,sm7150-qmp-ufs-phy
> -      - qcom,sm8150-qmp-ufs-phy
> -      - qcom,sm8250-qmp-ufs-phy
> -      - qcom,sm8350-qmp-ufs-phy
> -      - qcom,sm8450-qmp-ufs-phy
> -      - qcom,sm8475-qmp-ufs-phy
> -      - qcom,sm8550-qmp-ufs-phy
> -      - qcom,sm8650-qmp-ufs-phy
> +    oneOf:
> +      - items:
> +          - enum:
> +              - qcom,qcs8300-qmp-ufs-phy
> +          - const: qcom,sa8775p-qmp-ufs-phy
> +      - enum:
> +          - qcom,msm8996-qmp-ufs-phy
> +          - qcom,msm8998-qmp-ufs-phy
> +          - qcom,sa8775p-qmp-ufs-phy
> +          - qcom,sc7180-qmp-ufs-phy
> +          - qcom,sc7280-qmp-ufs-phy
> +          - qcom,sc8180x-qmp-ufs-phy
> +          - qcom,sc8280xp-qmp-ufs-phy
> +          - qcom,sdm845-qmp-ufs-phy
> +          - qcom,sm6115-qmp-ufs-phy
> +          - qcom,sm6125-qmp-ufs-phy
> +          - qcom,sm6350-qmp-ufs-phy
> +          - qcom,sm7150-qmp-ufs-phy
> +          - qcom,sm8150-qmp-ufs-phy
> +          - qcom,sm8250-qmp-ufs-phy
> +          - qcom,sm8350-qmp-ufs-phy
> +          - qcom,sm8450-qmp-ufs-phy
> +          - qcom,sm8475-qmp-ufs-phy
> +          - qcom,sm8550-qmp-ufs-phy
> +          - qcom,sm8650-qmp-ufs-phy
>  
>    reg:
>      maxItems: 1
> @@ -85,6 +90,7 @@ allOf:
>            contains:
>              enum:
>                - qcom,msm8998-qmp-ufs-phy
> +              - qcom,qcs8300-qmp-ufs-phy

Not needed.

BTW, please be sure you organize your patchsets per subsystem. IOW, that
you do not split same subsystem bindings patches into separate
patchsets.

Best regards,
Krzysztof
Re: [PATCH v2] dt-bindings: phy: Add QMP UFS PHY comptible for QCS8300
Posted by Jingyi Wang 2 months ago 

On 9/16/2024 10:53 PM, Krzysztof Kozlowski wrote:
> On Wed, Sep 11, 2024 at 02:56:16PM +0800, Jingyi Wang wrote:
>> From: Xin Liu <quic_liuxin@quicinc.com>
>>
>> Document the QMP UFS PHY compatible for Qualcomm QCS8300 to support
>> physical layer functionality for UFS found on the SoC. Use fallback to
>> indicate the compatibility of the QMP UFS PHY on the QCS8300 with that
>> on the SA8775P.
>>
>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
>> ---
>> Changes in v2:
>> - decoupled from the original series.
>> - Use fallback to indicate compatibility with SA8775P.
>> - typo fixup
>> - Link to v1: https://lore.kernel.org/r/20240904-qcs8300_initial_dtsi-v1-0-d0ea9afdc007@quicinc.com
>> ---
>>  .../bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml    | 46 ++++++++++++----------
>>  1 file changed, 26 insertions(+), 20 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
>> index f9cfbd0b2de6..626a2039e177 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
>> @@ -15,26 +15,31 @@ description:
>>  
>>  properties:
>>    compatible:
>> -    enum:
>> -      - qcom,msm8996-qmp-ufs-phy
>> -      - qcom,msm8998-qmp-ufs-phy
>> -      - qcom,sa8775p-qmp-ufs-phy
>> -      - qcom,sc7180-qmp-ufs-phy
>> -      - qcom,sc7280-qmp-ufs-phy
>> -      - qcom,sc8180x-qmp-ufs-phy
>> -      - qcom,sc8280xp-qmp-ufs-phy
>> -      - qcom,sdm845-qmp-ufs-phy
>> -      - qcom,sm6115-qmp-ufs-phy
>> -      - qcom,sm6125-qmp-ufs-phy
>> -      - qcom,sm6350-qmp-ufs-phy
>> -      - qcom,sm7150-qmp-ufs-phy
>> -      - qcom,sm8150-qmp-ufs-phy
>> -      - qcom,sm8250-qmp-ufs-phy
>> -      - qcom,sm8350-qmp-ufs-phy
>> -      - qcom,sm8450-qmp-ufs-phy
>> -      - qcom,sm8475-qmp-ufs-phy
>> -      - qcom,sm8550-qmp-ufs-phy
>> -      - qcom,sm8650-qmp-ufs-phy
>> +    oneOf:
>> +      - items:
>> +          - enum:
>> +              - qcom,qcs8300-qmp-ufs-phy
>> +          - const: qcom,sa8775p-qmp-ufs-phy
>> +      - enum:
>> +          - qcom,msm8996-qmp-ufs-phy
>> +          - qcom,msm8998-qmp-ufs-phy
>> +          - qcom,sa8775p-qmp-ufs-phy
>> +          - qcom,sc7180-qmp-ufs-phy
>> +          - qcom,sc7280-qmp-ufs-phy
>> +          - qcom,sc8180x-qmp-ufs-phy
>> +          - qcom,sc8280xp-qmp-ufs-phy
>> +          - qcom,sdm845-qmp-ufs-phy
>> +          - qcom,sm6115-qmp-ufs-phy
>> +          - qcom,sm6125-qmp-ufs-phy
>> +          - qcom,sm6350-qmp-ufs-phy
>> +          - qcom,sm7150-qmp-ufs-phy
>> +          - qcom,sm8150-qmp-ufs-phy
>> +          - qcom,sm8250-qmp-ufs-phy
>> +          - qcom,sm8350-qmp-ufs-phy
>> +          - qcom,sm8450-qmp-ufs-phy
>> +          - qcom,sm8475-qmp-ufs-phy
>> +          - qcom,sm8550-qmp-ufs-phy
>> +          - qcom,sm8650-qmp-ufs-phy
>>  
>>    reg:
>>      maxItems: 1
>> @@ -85,6 +90,7 @@ allOf:
>>            contains:
>>              enum:
>>                - qcom,msm8998-qmp-ufs-phy
>> +              - qcom,qcs8300-qmp-ufs-phy
> 
> Not needed.
> 
Well noted.
> BTW, please be sure you organize your patchsets per subsystem. IOW, that
> you do not split same subsystem bindings patches into separate
> patchsets.
> 
Do you mean combine the binding of qmp-ufs-phy with ufs controller? I noticed
that this patch belongs to "GENERIC PHY FRAMEWORK" subsystem and ufs controller
binding belongs to "UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER". If necessary,
we can pay attention to combine them next time
> Best regards,
> Krzysztof
> 
Thanks,
Jingyi
Re: [PATCH v2] dt-bindings: phy: Add QMP UFS PHY comptible for QCS8300
Posted by Krzysztof Kozlowski 2 months ago 
On 25/09/2024 05:16, Jingyi Wang wrote:
> 
> 
> On 9/16/2024 10:53 PM, Krzysztof Kozlowski wrote:
>> On Wed, Sep 11, 2024 at 02:56:16PM +0800, Jingyi Wang wrote:
>>> From: Xin Liu <quic_liuxin@quicinc.com>
>>>
>>> Document the QMP UFS PHY compatible for Qualcomm QCS8300 to support
>>> physical layer functionality for UFS found on the SoC. Use fallback to
>>> indicate the compatibility of the QMP UFS PHY on the QCS8300 with that
>>> on the SA8775P.
>>>
>>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
>>> ---
>>> Changes in v2:
>>> - decoupled from the original series.
>>> - Use fallback to indicate compatibility with SA8775P.
>>> - typo fixup
>>> - Link to v1: https://lore.kernel.org/r/20240904-qcs8300_initial_dtsi-v1-0-d0ea9afdc007@quicinc.com
>>> ---
>>>  .../bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml    | 46 ++++++++++++----------
>>>  1 file changed, 26 insertions(+), 20 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
>>> index f9cfbd0b2de6..626a2039e177 100644
>>> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
>>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
>>> @@ -15,26 +15,31 @@ description:
>>>  
>>>  properties:
>>>    compatible:
>>> -    enum:
>>> -      - qcom,msm8996-qmp-ufs-phy
>>> -      - qcom,msm8998-qmp-ufs-phy
>>> -      - qcom,sa8775p-qmp-ufs-phy
>>> -      - qcom,sc7180-qmp-ufs-phy
>>> -      - qcom,sc7280-qmp-ufs-phy
>>> -      - qcom,sc8180x-qmp-ufs-phy
>>> -      - qcom,sc8280xp-qmp-ufs-phy
>>> -      - qcom,sdm845-qmp-ufs-phy
>>> -      - qcom,sm6115-qmp-ufs-phy
>>> -      - qcom,sm6125-qmp-ufs-phy
>>> -      - qcom,sm6350-qmp-ufs-phy
>>> -      - qcom,sm7150-qmp-ufs-phy
>>> -      - qcom,sm8150-qmp-ufs-phy
>>> -      - qcom,sm8250-qmp-ufs-phy
>>> -      - qcom,sm8350-qmp-ufs-phy
>>> -      - qcom,sm8450-qmp-ufs-phy
>>> -      - qcom,sm8475-qmp-ufs-phy
>>> -      - qcom,sm8550-qmp-ufs-phy
>>> -      - qcom,sm8650-qmp-ufs-phy
>>> +    oneOf:
>>> +      - items:
>>> +          - enum:
>>> +              - qcom,qcs8300-qmp-ufs-phy
>>> +          - const: qcom,sa8775p-qmp-ufs-phy
>>> +      - enum:
>>> +          - qcom,msm8996-qmp-ufs-phy
>>> +          - qcom,msm8998-qmp-ufs-phy
>>> +          - qcom,sa8775p-qmp-ufs-phy
>>> +          - qcom,sc7180-qmp-ufs-phy
>>> +          - qcom,sc7280-qmp-ufs-phy
>>> +          - qcom,sc8180x-qmp-ufs-phy
>>> +          - qcom,sc8280xp-qmp-ufs-phy
>>> +          - qcom,sdm845-qmp-ufs-phy
>>> +          - qcom,sm6115-qmp-ufs-phy
>>> +          - qcom,sm6125-qmp-ufs-phy
>>> +          - qcom,sm6350-qmp-ufs-phy
>>> +          - qcom,sm7150-qmp-ufs-phy
>>> +          - qcom,sm8150-qmp-ufs-phy
>>> +          - qcom,sm8250-qmp-ufs-phy
>>> +          - qcom,sm8350-qmp-ufs-phy
>>> +          - qcom,sm8450-qmp-ufs-phy
>>> +          - qcom,sm8475-qmp-ufs-phy
>>> +          - qcom,sm8550-qmp-ufs-phy
>>> +          - qcom,sm8650-qmp-ufs-phy
>>>  
>>>    reg:
>>>      maxItems: 1
>>> @@ -85,6 +90,7 @@ allOf:
>>>            contains:
>>>              enum:
>>>                - qcom,msm8998-qmp-ufs-phy
>>> +              - qcom,qcs8300-qmp-ufs-phy
>>
>> Not needed.
>>
> Well noted.
>> BTW, please be sure you organize your patchsets per subsystem. IOW, that
>> you do not split same subsystem bindings patches into separate
>> patchsets.
>>
> Do you mean combine the binding of qmp-ufs-phy with ufs controller? I noticed
> that this patch belongs to "GENERIC PHY FRAMEWORK" subsystem and ufs controller
> binding belongs to "UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER". If necessary,
> we can pay attention to combine them next time

No, I mean group patches targeting the same subsystem.

Best regards,
Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.