ARM: dts: marvell: kirkwood: Fix at24 EEPROM node name

[PATCH] ARM: dts: marvell: kirkwood: Fix at24 EEPROM node name

Posted by Rob Herring (Arm) 1 year, 4 months ago

at24.yaml defines the node name for at24 EEPROMs as 'eeprom'.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts b/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts
index 9c438f10f737..2bc4b68bd723 100644
--- a/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts
+++ b/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts
@@ -44,7 +44,7 @@ sata@80000 {
 		i2c@11100 {
 			status = "okay";
 
-			s24c02: s24c02@50 {
+			s24c02: eeprom@50 {
 				compatible = "atmel,24c02";
 				reg = <0x50>;
 			};
-- 
2.45.2

Re: [PATCH] ARM: dts: marvell: kirkwood: Fix at24 EEPROM node name

Posted by Rob Herring 1 year, 3 months ago

On Tue, Sep 10, 2024 at 4:59 PM Rob Herring (Arm) <robh@kernel.org> wrote:
>
> at24.yaml defines the node name for at24 EEPROMs as 'eeprom'.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ping!

Are Marvell platforms still maintained?

>
> diff --git a/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts b/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts
> index 9c438f10f737..2bc4b68bd723 100644
> --- a/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts
> +++ b/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts
> @@ -44,7 +44,7 @@ sata@80000 {
>                 i2c@11100 {
>                         status = "okay";
>
> -                       s24c02: s24c02@50 {
> +                       s24c02: eeprom@50 {
>                                 compatible = "atmel,24c02";
>                                 reg = <0x50>;
>                         };
> --
> 2.45.2
>

Re: [PATCH] ARM: dts: marvell: kirkwood: Fix at24 EEPROM node name

Posted by Gregory CLEMENT 1 year, 3 months ago

Hello Rob,

> On Tue, Sep 10, 2024 at 4:59 PM Rob Herring (Arm) <robh@kernel.org> wrote:
>>
>> at24.yaml defines the node name for at24 EEPROMs as 'eeprom'.
>>
>> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
>> ---
>>  arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Ping!
>
> Are Marvell platforms still maintained?

Actually I just applied it this morning, and was about to notify about
it.

Applied on mvebu/dt

Thanks,

Gregory

>
>>
>> diff --git a/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts b/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts
>> index 9c438f10f737..2bc4b68bd723 100644
>> --- a/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts
>> +++ b/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts
>> @@ -44,7 +44,7 @@ sata@80000 {
>>                 i2c@11100 {
>>                         status = "okay";
>>
>> -                       s24c02: s24c02@50 {
>> +                       s24c02: eeprom@50 {
>>                                 compatible = "atmel,24c02";
>>                                 reg = <0x50>;
>>                         };
>> --
>> 2.45.2
>>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH] ARM: dts: marvell: kirkwood: Fix at24 EEPROM node name

Posted by Andrew Lunn 1 year, 3 months ago

On Mon, Nov 04, 2024 at 07:24:50AM -0600, Rob Herring wrote:
> On Tue, Sep 10, 2024 at 4:59 PM Rob Herring (Arm) <robh@kernel.org> wrote:
> >
> > at24.yaml defines the node name for at24 EEPROMs as 'eeprom'.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > ---
> >  arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Ping!
> 
> Are Marvell platforms still maintained?

Yes, but on a sporadic basis. Patches tend to get collected somewhere
around -rc5/-rc6. So i would expect a notification from Gregory
sometime this week.

	Andrew

Re: [PATCH] ARM: dts: marvell: kirkwood: Fix at24 EEPROM node name

Posted by Andrew Lunn 1 year, 4 months ago

On Tue, Sep 10, 2024 at 04:59:13PM -0500, Rob Herring (Arm) wrote:
> at24.yaml defines the node name for at24 EEPROMs as 'eeprom'.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew