Hi Laurent,
Thank you for the review.
On Fri, Sep 27, 2024 at 11:26 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Tue, Sep 10, 2024 at 06:53:45PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Make use of NR_OF_RZG2L_CSI2_PAD enum entry in media_entity_pads_init()
> > instead of magic number.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> > index 2f4c87ede8bf..10b8b0c87c1f 100644
> > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c
> > @@ -804,7 +804,7 @@ static int rzg2l_csi2_probe(struct platform_device *pdev)
> > */
> > csi2->pads[RZG2L_CSI2_SOURCE].flags = MEDIA_PAD_FL_SOURCE |
> > MEDIA_PAD_FL_MUST_CONNECT;
> > - ret = media_entity_pads_init(&csi2->subdev.entity, 2, csi2->pads);
> > + ret = media_entity_pads_init(&csi2->subdev.entity, NR_OF_RZG2L_CSI2_PAD, csi2->pads);
>
> Better, I would use ARRAY_SIZE
>
> ret = media_entity_pads_init(&csi2->subdev.entity, ARRAY_SIZE(csi2->pads),
> csi2->pads);
>
> With this (and an updated commit message),
>
Ok, I will update the code to above suggestion and update the commit
description.
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
And I will add the RB tag.
Cheers,
Prabhakar