From: Shawn Shao <shawn.shao@jaguarmicro.com>

The current PLDM library does not support parsing the
DeviceUpdateOptionFlags parameter, which is defined in
the PLDM specification to facilitate the transfer of
control information between the UA (Update Agent) and
the firmware.Please refer to:
https://www.dmtf.org/sites/default/files/standards/
documents/DSP0267_1.3.0.pdf P37.

Signed-off-by: Shawn Shao <shawn.shao@jaguarmicro.com>
---
 lib/pldmfw/pldmfw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/pldmfw/pldmfw.c b/lib/pldmfw/pldmfw.c
index 15ba5f76043f..cd1698e9c340 100644
--- a/lib/pldmfw/pldmfw.c
+++ b/lib/pldmfw/pldmfw.c
@@ -306,6 +306,7 @@ pldm_parse_one_record(struct pldmfw_priv *data,
 		return err;
 
 	record_len = get_unaligned_le16(&__record->record_len);
+	record->device_update_flags = get_unaligned_le32(&__record->device_update_flags);
 	record->package_data_len = get_unaligned_le16(&__record->package_data_len);
 	record->version_len = __record->version_len;
 	record->version_type = __record->version_type;
-- 
2.34.1

On 9/9/2024 8:03 PM, Shawn.Shao wrote:
> From: Shawn Shao <shawn.shao@jaguarmicro.com>
> 
> The current PLDM library does not support parsing the
> DeviceUpdateOptionFlags parameter, which is defined in
> the PLDM specification to facilitate the transfer of
> control information between the UA (Update Agent) and
> the firmware.Please refer to:
> https://www.dmtf.org/sites/default/files/standards/
> documents/DSP0267_1.3.0.pdf P37.

Just to confirm this is also spelled out in the 1.0.0 standard on page
26, available at:

https://www.dmtf.org/sites/default/files/standards/documents/DSP0267_1.0.0.pdf


That's important since we currently only support the initial 1.0.0
standard format.

Thanks for fixing this oversight.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>