perf parse-events: Remove duplicated include in parse-events.c

[PATCH -next] perf parse-events: Remove duplicated include in parse-events.c

Posted by Yang Li 2 months, 3 weeks ago

The header files parse-events.h is included twice in parse-events.c,
so one inclusion of each can be removed.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10822
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 tools/perf/tests/parse-events.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
index 639e65a9bf61..e228511c85a5 100644
--- a/tools/perf/tests/parse-events.c
+++ b/tools/perf/tests/parse-events.c
@@ -5,7 +5,6 @@
 #include <api/fs/fs.h>
 #include "tests.h"
 #include "debug.h"
-#include "parse-events.h"
 #include "pmu.h"
 #include "pmus.h"
 #include <dirent.h>
-- 
2.32.0.3.g01195cf9f

Re: [PATCH -next] perf parse-events: Remove duplicated include in parse-events.c

Posted by James Clark 2 months, 2 weeks ago


On 10/09/2024 01:55, Yang Li wrote:
> The header files parse-events.h is included twice in parse-events.c,
> so one inclusion of each can be removed.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10822
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   tools/perf/tests/parse-events.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
> index 639e65a9bf61..e228511c85a5 100644
> --- a/tools/perf/tests/parse-events.c
> +++ b/tools/perf/tests/parse-events.c
> @@ -5,7 +5,6 @@
>   #include <api/fs/fs.h>
>   #include "tests.h"
>   #include "debug.h"
> -#include "parse-events.h"
>   #include "pmu.h"
>   #include "pmus.h"
>   #include <dirent.h>

Reviewed-by: James Clark <james.clark@linaro.org>

Re: [PATCH -next] perf parse-events: Remove duplicated include in parse-events.c

Posted by Arnaldo Carvalho de Melo 2 months, 2 weeks ago

On Wed, Sep 11, 2024 at 10:50:33AM +0100, James Clark wrote:
> 
> 
> On 10/09/2024 01:55, Yang Li wrote:
> > The header files parse-events.h is included twice in parse-events.c,
> > so one inclusion of each can be removed.
> > 
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10822
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> >   tools/perf/tests/parse-events.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
> > index 639e65a9bf61..e228511c85a5 100644
> > --- a/tools/perf/tests/parse-events.c
> > +++ b/tools/perf/tests/parse-events.c
> > @@ -5,7 +5,6 @@
> >   #include <api/fs/fs.h>
> >   #include "tests.h"
> >   #include "debug.h"
> > -#include "parse-events.h"
> >   #include "pmu.h"
> >   #include "pmus.h"
> >   #include <dirent.h>
> 
> Reviewed-by: James Clark <james.clark@linaro.org>

Thanks, applied to perf-tools-next,

- Arnaldo