block, bfq: bfqq merge chain fixes and cleanup

[PATCH for-6.12 0/7] block, bfq: bfqq merge chain fixes and cleanup

Posted by Yu Kuai 2 months, 3 weeks ago

From: Yu Kuai <yukuai3@huawei.com>

Patch 1 fixes a problem found by xfstests generic/323, tested on scsi
disk with bfq.
Patch 2 fixes a problem while digging the above problem, by a debug patch
to print procress reference.
Patch 3-7 are cleanups while reviewing code.

Yu Kuai (7):
  block, bfq: fix uaf for accessing waker_bfqq after splitting
  block, bfq: fix procress reference leakage for bfqq in merge chain
  block, bfq: merge bfq_release_process_ref() into bfq_put_cooperator()
  block, bfq: remove bfq_log_bfqg()
  block, bfq: remove local variable 'split' in bfq_init_rq()
  block, bfq: remove local variable 'bfqq_already_existing' in
    bfq_init_rq()
  block, bfq: factor out a helper to split bfqq in bfq_init_rq()

 block/bfq-cgroup.c  |   1 -
 block/bfq-iosched.c | 191 ++++++++++++++++++++++++--------------------
 block/bfq-iosched.h |   6 --
 3 files changed, 103 insertions(+), 95 deletions(-)

-- 
2.39.2

Re: [PATCH for-6.12 0/7] block, bfq: bfqq merge chain fixes and cleanup

Posted by Jens Axboe 2 months, 2 weeks ago

On Mon, 09 Sep 2024 21:41:47 +0800, Yu Kuai wrote:
> Patch 1 fixes a problem found by xfstests generic/323, tested on scsi
> disk with bfq.
> Patch 2 fixes a problem while digging the above problem, by a debug patch
> to print procress reference.
> Patch 3-7 are cleanups while reviewing code.
> 
> Yu Kuai (7):
>   block, bfq: fix uaf for accessing waker_bfqq after splitting
>   block, bfq: fix procress reference leakage for bfqq in merge chain
>   block, bfq: merge bfq_release_process_ref() into bfq_put_cooperator()
>   block, bfq: remove bfq_log_bfqg()
>   block, bfq: remove local variable 'split' in bfq_init_rq()
>   block, bfq: remove local variable 'bfqq_already_existing' in
>     bfq_init_rq()
>   block, bfq: factor out a helper to split bfqq in bfq_init_rq()
> 
> [...]

Applied, thanks!

[1/7] block, bfq: fix uaf for accessing waker_bfqq after splitting
      commit: 1ba0403ac6447f2d63914fb760c44a3b19c44eaf
[2/7] block, bfq: fix procress reference leakage for bfqq in merge chain
      commit: 73aeab373557fa6ee4ae0b742c6211ccd9859280
[3/7] block, bfq: merge bfq_release_process_ref() into bfq_put_cooperator()
      commit: bc3b1e9e7c50e1de0f573eea3871db61dd4787de
[4/7] block, bfq: remove bfq_log_bfqg()
      commit: 553a606c25f8ff5c518c7fcf488dd4dd5fbb4795
[5/7] block, bfq: remove local variable 'split' in bfq_init_rq()
      commit: e61e002a67da9ec36571af743c94a968cf1ce116
[6/7] block, bfq: remove local variable 'bfqq_already_existing' in bfq_init_rq()
      commit: 3c61429c297582e0da7231fb29fc5ec1d2c7d1b2
[7/7] block, bfq: factor out a helper to split bfqq in bfq_init_rq()
      commit: a7609d2aec67ec16220036a5b1b14610883cdbd3

Best regards,
-- 
Jens Axboe