cpufreq: use proper units for frequency

[PATCH] cpufreq: use proper units for frequency

Posted by Marcin Juszkiewicz 2 months, 3 weeks ago

When I booted my RK3588 based system I noticed that cpufreq complained
about system clock:

[  +0.007211] cpufreq: cpufreq_online: CPU0: Running at unlisted initial frequency: 816000 KHz, changing to: 1008000 KHz

Then I realized that unit is displayed wrong: "KHz" instead of "kHz".

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 drivers/cpufreq/cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 04fc786dd2c0..76da29c2bd3f 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1539,7 +1539,7 @@ static int cpufreq_online(unsigned int cpu)
 			 * frequency for longer duration. Hence, a BUG_ON().
 			 */
 			BUG_ON(ret);
-			pr_info("%s: CPU%d: Running at unlisted initial frequency: %u KHz, changing to: %u KHz\n",
+			pr_info("%s: CPU%d: Running at unlisted initial frequency: %u kHz, changing to: %u kHz\n",
 				__func__, policy->cpu, old_freq, policy->cur);
 		}
 	}
-- 
2.46.0

Re: [PATCH] cpufreq: use proper units for frequency

Posted by Viresh Kumar 2 months, 1 week ago

On Mon, 9 Sept 2024 at 15:25, Marcin Juszkiewicz
<marcin.juszkiewicz@linaro.org> wrote:
>
> When I booted my RK3588 based system I noticed that cpufreq complained
> about system clock:
>
> [  +0.007211] cpufreq: cpufreq_online: CPU0: Running at unlisted initial frequency: 816000 KHz, changing to: 1008000 KHz
>
> Then I realized that unit is displayed wrong: "KHz" instead of "kHz".
>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
>  drivers/cpufreq/cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 04fc786dd2c0..76da29c2bd3f 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1539,7 +1539,7 @@ static int cpufreq_online(unsigned int cpu)
>                          * frequency for longer duration. Hence, a BUG_ON().
>                          */
>                         BUG_ON(ret);
> -                       pr_info("%s: CPU%d: Running at unlisted initial frequency: %u KHz, changing to: %u KHz\n",
> +                       pr_info("%s: CPU%d: Running at unlisted initial frequency: %u kHz, changing to: %u kHz\n",
>                                 __func__, policy->cpu, old_freq, policy->cur);
>                 }
>         }

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Re: [PATCH] cpufreq: use proper units for frequency

Posted by Rafael J. Wysocki 1 month, 1 week ago

On Wed, Sep 18, 2024 at 5:04 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On Mon, 9 Sept 2024 at 15:25, Marcin Juszkiewicz
> <marcin.juszkiewicz@linaro.org> wrote:
> >
> > When I booted my RK3588 based system I noticed that cpufreq complained
> > about system clock:
> >
> > [  +0.007211] cpufreq: cpufreq_online: CPU0: Running at unlisted initial frequency: 816000 KHz, changing to: 1008000 KHz
> >
> > Then I realized that unit is displayed wrong: "KHz" instead of "kHz".
> >
> > Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> > ---
> >  drivers/cpufreq/cpufreq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index 04fc786dd2c0..76da29c2bd3f 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -1539,7 +1539,7 @@ static int cpufreq_online(unsigned int cpu)
> >                          * frequency for longer duration. Hence, a BUG_ON().
> >                          */
> >                         BUG_ON(ret);
> > -                       pr_info("%s: CPU%d: Running at unlisted initial frequency: %u KHz, changing to: %u KHz\n",
> > +                       pr_info("%s: CPU%d: Running at unlisted initial frequency: %u kHz, changing to: %u kHz\n",
> >                                 __func__, policy->cpu, old_freq, policy->cur);
> >                 }
> >         }
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Applied as 6.13 material, thanks!