irqchip/riscv-imsic: Fix output text of base address

[PATCH] irqchip/riscv-imsic: Fix output text of base address

Posted by Andrew Jones 1 year, 5 months ago

The "per-CPU IDs ... at base ..." info log is outputting a physical
address, not a PPN.

Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
---
 drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 11723a763c10..c5ec66e0bfd3 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -340,7 +340,7 @@ int imsic_irqdomain_init(void)
 		imsic->fwnode, global->hart_index_bits, global->guest_index_bits);
 	pr_info("%pfwP: group-index-bits: %d, group-index-shift: %d\n",
 		imsic->fwnode, global->group_index_bits, global->group_index_shift);
-	pr_info("%pfwP: per-CPU IDs %d at base PPN %pa\n",
+	pr_info("%pfwP: per-CPU IDs %d at base address %pa\n",
 		imsic->fwnode, global->nr_ids, &global->base_addr);
 	pr_info("%pfwP: total %d interrupts available\n",
 		imsic->fwnode, num_possible_cpus() * (global->nr_ids - 1));
-- 
2.46.0

Re: [PATCH] irqchip/riscv-imsic: Fix output text of base address

Posted by Anup Patel 1 year, 5 months ago

On Mon, Sep 9, 2024 at 2:26 PM Andrew Jones <ajones@ventanamicro.com> wrote:
>
> The "per-CPU IDs ... at base ..." info log is outputting a physical
> address, not a PPN.
>
> Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
> Signed-off-by: Andrew Jones <ajones@ventanamicro.com>

LGTM.

Reviewed-by: Anup Patel <anup@brainfault.org>

Regards,
Anup

> ---
>  drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
> index 11723a763c10..c5ec66e0bfd3 100644
> --- a/drivers/irqchip/irq-riscv-imsic-platform.c
> +++ b/drivers/irqchip/irq-riscv-imsic-platform.c
> @@ -340,7 +340,7 @@ int imsic_irqdomain_init(void)
>                 imsic->fwnode, global->hart_index_bits, global->guest_index_bits);
>         pr_info("%pfwP: group-index-bits: %d, group-index-shift: %d\n",
>                 imsic->fwnode, global->group_index_bits, global->group_index_shift);
> -       pr_info("%pfwP: per-CPU IDs %d at base PPN %pa\n",
> +       pr_info("%pfwP: per-CPU IDs %d at base address %pa\n",
>                 imsic->fwnode, global->nr_ids, &global->base_addr);
>         pr_info("%pfwP: total %d interrupts available\n",
>                 imsic->fwnode, num_possible_cpus() * (global->nr_ids - 1));
> --
> 2.46.0
>

[tip: irq/urgent] irqchip/riscv-imsic: Fix output text of base address

Posted by tip-bot2 for Andrew Jones 1 year, 4 months ago

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID:     4a1361e9a5c5dbb5c9f647762ae0cb1a605101fa
Gitweb:        https://git.kernel.org/tip/4a1361e9a5c5dbb5c9f647762ae0cb1a605101fa
Author:        Andrew Jones <ajones@ventanamicro.com>
AuthorDate:    Mon, 09 Sep 2024 10:56:11 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 02 Oct 2024 15:12:18 +02:00

irqchip/riscv-imsic: Fix output text of base address

The "per-CPU IDs ... at base ..." info log is outputting a physical
address, not a PPN.

Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/all/20240909085610.46625-2-ajones@ventanamicro.com

---
 drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 64905e6..c708780 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -341,7 +341,7 @@ int imsic_irqdomain_init(void)
 		imsic->fwnode, global->hart_index_bits, global->guest_index_bits);
 	pr_info("%pfwP: group-index-bits: %d, group-index-shift: %d\n",
 		imsic->fwnode, global->group_index_bits, global->group_index_shift);
-	pr_info("%pfwP: per-CPU IDs %d at base PPN %pa\n",
+	pr_info("%pfwP: per-CPU IDs %d at base address %pa\n",
 		imsic->fwnode, global->nr_ids, &global->base_addr);
 	pr_info("%pfwP: total %d interrupts available\n",
 		imsic->fwnode, num_possible_cpus() * (global->nr_ids - 1));