[v2] random: Resolve circular include dependency and include <linux/percpu.h>

[PATCH RESEND v2 07/19] fscrypt: Include <linux/once.h> in fs/crypto/keyring.c

Posted by Uros Bizjak 2 months, 3 weeks ago

Include <linux/once.h> header to allow the removal of legacy
inclusion of <linux/prandom.h> from <linux/random.h>.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: Eric Biggers <ebiggers@kernel.org>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
---
v2: Include <linux/once.h> instead of <linux/prandom.h>
---
 fs/crypto/keyring.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/crypto/keyring.c b/fs/crypto/keyring.c
index 6681a71625f0..82fcc5683649 100644
--- a/fs/crypto/keyring.c
+++ b/fs/crypto/keyring.c
@@ -22,6 +22,7 @@
 #include <crypto/skcipher.h>
 #include <linux/key-type.h>
 #include <linux/random.h>
+#include <linux/once.h>
 #include <linux/seq_file.h>
 
 #include "fscrypt_private.h"
-- 
2.46.0

Re: [PATCH RESEND v2 07/19] fscrypt: Include <linux/once.h> in fs/crypto/keyring.c

Posted by Eric Biggers 2 months, 2 weeks ago

On Mon, Sep 09, 2024 at 09:53:50AM +0200, Uros Bizjak wrote:
> Include <linux/once.h> header to allow the removal of legacy
> inclusion of <linux/prandom.h> from <linux/random.h>.
> 
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> Cc: Eric Biggers <ebiggers@kernel.org>
> Cc: "Theodore Y. Ts'o" <tytso@mit.edu>
> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> v2: Include <linux/once.h> instead of <linux/prandom.h>
> ---
>  fs/crypto/keyring.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/crypto/keyring.c b/fs/crypto/keyring.c
> index 6681a71625f0..82fcc5683649 100644
> --- a/fs/crypto/keyring.c
> +++ b/fs/crypto/keyring.c
> @@ -22,6 +22,7 @@
>  #include <crypto/skcipher.h>
>  #include <linux/key-type.h>
>  #include <linux/random.h>
> +#include <linux/once.h>
>  #include <linux/seq_file.h>
>  
>  #include "fscrypt_private.h"

Acked-by: Eric Biggers <ebiggers@google.com>

- Eric