[v2] ALSA: hda/cs8409: Support new Dell Dolphin for device

[PATCH v2] ALSA: hda/cs8409: Support new Dell Dolphin for device

Posted by zenghongling 2 months, 3 weeks ago

Add 1 new Dell Dolphin Systems, same configuration as older systems.

Signed-off-by: zenghongling <zenghongling@kylinos.cn>
---
 sound/pci/hda/patch_cs8409-tables.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_cs8409-tables.c b/sound/pci/hda/patch_cs8409-tables.c
index 36b411d1..be0cc48 100644
--- a/sound/pci/hda/patch_cs8409-tables.c
+++ b/sound/pci/hda/patch_cs8409-tables.c
@@ -541,6 +541,7 @@ const struct snd_pci_quirk cs8409_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1028, 0x0BBB, "Warlock MLK Dual Mic", CS8409_WARLOCK_MLK_DUAL_MIC),
 	SND_PCI_QUIRK(0x1028, 0x0BBC, "Warlock MLK", CS8409_WARLOCK_MLK),
 	SND_PCI_QUIRK(0x1028, 0x0BBD, "Warlock MLK Dual Mic", CS8409_WARLOCK_MLK_DUAL_MIC),
+	SND_PCI_QUIRK(0x1028, 0x0BAA, "Dolphin", CS8409_DOLPHIN),
 	SND_PCI_QUIRK(0x1028, 0x0BD4, "Dolphin", CS8409_DOLPHIN),
 	SND_PCI_QUIRK(0x1028, 0x0BD5, "Dolphin", CS8409_DOLPHIN),
 	SND_PCI_QUIRK(0x1028, 0x0BD6, "Dolphin", CS8409_DOLPHIN),
-- 
2.1.0

Re: [PATCH v2] ALSA: hda/cs8409: Support new Dell Dolphin for device

Posted by Takashi Iwai 2 months, 3 weeks ago

On Mon, 09 Sep 2024 03:44:57 +0200,
zenghongling wrote:
> 
> Add 1 new Dell Dolphin Systems, same configuration as older systems.
> 
> Signed-off-by: zenghongling <zenghongling@kylinos.cn>
> ---
>  sound/pci/hda/patch_cs8409-tables.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_cs8409-tables.c b/sound/pci/hda/patch_cs8409-tables.c
> index 36b411d1..be0cc48 100644
> --- a/sound/pci/hda/patch_cs8409-tables.c
> +++ b/sound/pci/hda/patch_cs8409-tables.c
> @@ -541,6 +541,7 @@ const struct snd_pci_quirk cs8409_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1028, 0x0BBB, "Warlock MLK Dual Mic", CS8409_WARLOCK_MLK_DUAL_MIC),
>  	SND_PCI_QUIRK(0x1028, 0x0BBC, "Warlock MLK", CS8409_WARLOCK_MLK),
>  	SND_PCI_QUIRK(0x1028, 0x0BBD, "Warlock MLK Dual Mic", CS8409_WARLOCK_MLK_DUAL_MIC),
> +	SND_PCI_QUIRK(0x1028, 0x0BAA, "Dolphin", CS8409_DOLPHIN),
>  	SND_PCI_QUIRK(0x1028, 0x0BD4, "Dolphin", CS8409_DOLPHIN),
>  	SND_PCI_QUIRK(0x1028, 0x0BD5, "Dolphin", CS8409_DOLPHIN),
>  	SND_PCI_QUIRK(0x1028, 0x0BD6, "Dolphin", CS8409_DOLPHIN),

1028:0BAA is already present for ODIN.  Conflicting setup?

(And you should try to put the entry at the right position; the table
is sorted in PCI SSID order.  If you did that, you should have noticed
the confliction more easily.)


Takashi