dt-binding: touchscreen: fix x-plat-ohm missing type definition

[PATCH] dt-binding: touchscreen: fix x-plat-ohm missing type definition

Posted by Sayyad Abid 2 months, 3 weeks ago

This patch fixes the issue with x-plat-ohm missing a type definition.
The patch adds the fix for this issue by adding value of this property
should be a 32-bit unsigned integer.

Signed-off-by: Sayyad Abid <sayyad.abid16@gmail.com>

---
 .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml       | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
index 7187c390b2f5..98ff65cf9f9f 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
@@ -38,6 +38,8 @@ properties:
 
   ti,x-plate-ohms:
     description: resistance of the touchscreen's X plates in ohm (defaults to 280)
+    $ref: /schemas/types.yaml#/definitions/uint32
+
 
   ti,esd-recovery-timeout-ms:
     description: |
-- 
2.39.2

Re: [PATCH] dt-binding: touchscreen: fix x-plat-ohm missing type definition

Posted by Krzysztof Kozlowski 2 months, 3 weeks ago

On Sun, Sep 08, 2024 at 08:47:43PM +0530, Sayyad Abid wrote:
> This patch fixes the issue with x-plat-ohm missing a type definition.
> The patch adds the fix for this issue by adding value of this property

You repeated twice the same while it is unclear why this is missing.

Also:
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95


> should be a 32-bit unsigned integer.
> 
> Signed-off-by: Sayyad Abid <sayyad.abid16@gmail.com>
> 
> ---
>  .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml       | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
> index 7187c390b2f5..98ff65cf9f9f 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
> @@ -38,6 +38,8 @@ properties:
>  
>    ti,x-plate-ohms:
>      description: resistance of the touchscreen's X plates in ohm (defaults to 280)

> +    $ref: /schemas/types.yaml#/definitions/uint32

$ref should not be needed, so what is exactly missing? Provide some
sort of proof that you are fixing real issue.

> +

Just one blank line.


Best regards,
Krzysztof