[PATCH] perf tools: Fix a typo

Andrew Kreimer posted 1 patch 2 months, 3 weeks ago
tools/perf/builtin-help.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] perf tools: Fix a typo
Posted by Andrew Kreimer 2 months, 3 weeks ago
Fix a typo in comments.

Reported-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
 tools/perf/builtin-help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
index b2a368ae295a..0854d3cd9f6a 100644
--- a/tools/perf/builtin-help.c
+++ b/tools/perf/builtin-help.c
@@ -417,7 +417,7 @@ static void open_html(const char *path)
 static int show_html_page(const char *perf_cmd)
 {
 	const char *page = cmd_to_page(perf_cmd);
-	char *page_path; /* it leaks but we exec bellow */
+	char *page_path; /* it leaks but we exec below */
 
 	if (get_html_page_path(&page_path, page) < 0)
 		return -1;
-- 
2.46.0
Re: [PATCH] perf tools: Fix a typo
Posted by Ian Rogers 2 months, 3 weeks ago
On Sat, Sep 7, 2024 at 6:10 AM Andrew Kreimer <algonell@gmail.com> wrote:
>
> Fix a typo in comments.
>
> Reported-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-help.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
> index b2a368ae295a..0854d3cd9f6a 100644
> --- a/tools/perf/builtin-help.c
> +++ b/tools/perf/builtin-help.c
> @@ -417,7 +417,7 @@ static void open_html(const char *path)
>  static int show_html_page(const char *perf_cmd)
>  {
>         const char *page = cmd_to_page(perf_cmd);
> -       char *page_path; /* it leaks but we exec bellow */
> +       char *page_path; /* it leaks but we exec below */
>
>         if (get_html_page_path(&page_path, page) < 0)
>                 return -1;
> --
> 2.46.0
>
Re: [PATCH] perf tools: Fix a typo
Posted by Arnaldo Carvalho de Melo 2 months, 2 weeks ago
On Sun, Sep 08, 2024 at 05:30:36PM -0700, Ian Rogers wrote:
> On Sat, Sep 7, 2024 at 6:10 AM Andrew Kreimer <algonell@gmail.com> wrote:
> >
> > Fix a typo in comments.
> >
> > Reported-by: Matthew Wilcox <willy@infradead.org>
> > Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks, applied to perf-tools-next,

- Arnaldo