[v1] Tool and hwmon PMUs

[PATCH v1 00/15] Tool and hwmon PMUs

Posted by Ian Rogers 2 months, 3 weeks ago

Rather than have fake and tool PMUs being special flags in an evsel,
create special PMUs. This allows, for example, duration_time to also
be tool/duration_time/. Once adding events to the tools PMU is just
adding to an array, add events for nearly all the expr literals like
num_cpus_online. Rather than create custom logic for finding and
describing the tool events use json and add a notion of common json
for the tool events.

Following the convention of the tool PMU, create a hwmon PMU that
exposes hwmon data for reading. For example, the following shows
reading the CPU temperature and 2 fan speeds alongside the uncore
frequency:
```
$ perf stat -e temp_cpu,fan1,hwmon_thinkpad/fan2/,tool/num_cpus_online/ -M UNCORE_FREQ -I 1000
     1.001153138              52.00 'C   temp_cpu
     1.001153138              2,588 rpm  fan1
     1.001153138              2,482 rpm  hwmon_thinkpad/fan2/
     1.001153138                  8      tool/num_cpus_online/
     1.001153138      1,077,101,397      UNC_CLOCK.SOCKET                 #     1.08 UNCORE_FREQ
     1.001153138      1,012,773,595      duration_time
...
```

Additional data on the hwmon events is in perf list:
```
$ perf list
...
hwmon:
...
  temp_core_0 OR temp2
       [Temperature in unit coretemp named Core 0. crit=100'C,max=100'C crit_alarm=0'C. Unit:
        hwmon_coretemp]
...
```

Ian Rogers (15):
  perf list: Avoid potential out of bounds memory read
  perf pmus: Fake PMU clean up
  perf evsel: Add accessor for tool_event
  perf pmu: To info add event_type_desc
  perf pmu: Allow hardcoded terms to be applied to attributes
  perf parse-events: Expose/rename config_term_name
  perf tool_pmu: Factor tool events into their own PMU
  perf tool_pmu: Rename enum perf_tool_event to tool_pmu_event
  perf tool_pmu: Rename perf_tool_event__* to tool_pmu__*
  perf tool_pmu: Move expr literals to tool_pmu
  perf jevents: Add tool event json under a common architecture
  perf tool_pmu: Switch to standard pmu functions and json descriptions
  perf tests: Add tool PMU test
  perf hwmon_pmu: Add a tool PMU exposing events from hwmon in sysfs
  perf docs: Document tool and hwmon events

 tools/perf/Documentation/perf-list.txt        |  15 +
 tools/perf/arch/arm64/util/pmu.c              |   5 +-
 tools/perf/arch/x86/util/intel-pt.c           |   3 +-
 tools/perf/arch/x86/util/tsc.c                |  16 +-
 tools/perf/builtin-list.c                     |  15 +-
 tools/perf/builtin-stat.c                     |   7 +-
 .../pmu-events/arch/common/common/tool.json   |  74 ++
 tools/perf/pmu-events/empty-pmu-events.c      | 208 +++--
 tools/perf/pmu-events/jevents.py              |  16 +-
 tools/perf/tests/Build                        |   1 +
 tools/perf/tests/builtin-test.c               |   1 +
 tools/perf/tests/parse-events.c               |   4 +-
 tools/perf/tests/pmu-events.c                 |  12 +-
 tools/perf/tests/pmu.c                        |   3 +-
 tools/perf/tests/tests.h                      |   1 +
 tools/perf/tests/tool_pmu.c                   | 111 +++
 tools/perf/util/Build                         |   2 +
 tools/perf/util/evsel.c                       | 287 +-----
 tools/perf/util/evsel.h                       |  23 +-
 tools/perf/util/expr.c                        |  93 +-
 tools/perf/util/hwmon_pmu.c                   | 879 ++++++++++++++++++
 tools/perf/util/hwmon_pmu.h                   |  30 +
 tools/perf/util/metricgroup.c                 |  45 +-
 tools/perf/util/parse-events.c                |  92 +-
 tools/perf/util/parse-events.h                |  13 +-
 tools/perf/util/parse-events.l                |  11 -
 tools/perf/util/parse-events.y                |  16 -
 tools/perf/util/pmu.c                         | 108 ++-
 tools/perf/util/pmu.h                         |  17 +-
 tools/perf/util/pmus.c                        |  25 +-
 tools/perf/util/pmus.h                        |   1 +
 tools/perf/util/print-events.c                |  36 +-
 tools/perf/util/print-events.h                |   1 -
 tools/perf/util/stat-display.c                |  14 +-
 tools/perf/util/stat-shadow.c                 |  24 +-
 tools/perf/util/tool_pmu.c                    | 508 ++++++++++
 tools/perf/util/tool_pmu.h                    |  56 ++
 tools/perf/util/tsc.h                         |   2 +-
 38 files changed, 2116 insertions(+), 659 deletions(-)
 create mode 100644 tools/perf/pmu-events/arch/common/common/tool.json
 create mode 100644 tools/perf/tests/tool_pmu.c
 create mode 100644 tools/perf/util/hwmon_pmu.c
 create mode 100644 tools/perf/util/hwmon_pmu.h
 create mode 100644 tools/perf/util/tool_pmu.c
 create mode 100644 tools/perf/util/tool_pmu.h

-- 
2.46.0.469.g59c65b2a67-goog

Re: [PATCH v1 00/15] Tool and hwmon PMUs

Posted by Ian Rogers 2 months, 3 weeks ago

On Fri, Sep 6, 2024 at 10:08 PM Ian Rogers <irogers@google.com> wrote:
>
> Rather than have fake and tool PMUs being special flags in an evsel,
> create special PMUs. This allows, for example, duration_time to also
> be tool/duration_time/. Once adding events to the tools PMU is just
> adding to an array, add events for nearly all the expr literals like
> num_cpus_online. Rather than create custom logic for finding and
> describing the tool events use json and add a notion of common json
> for the tool events.
>
> Following the convention of the tool PMU, create a hwmon PMU that
> exposes hwmon data for reading. For example, the following shows
> reading the CPU temperature and 2 fan speeds alongside the uncore
> frequency:
> ```
> $ perf stat -e temp_cpu,fan1,hwmon_thinkpad/fan2/,tool/num_cpus_online/ -M UNCORE_FREQ -I 1000
>      1.001153138              52.00 'C   temp_cpu
>      1.001153138              2,588 rpm  fan1
>      1.001153138              2,482 rpm  hwmon_thinkpad/fan2/
>      1.001153138                  8      tool/num_cpus_online/
>      1.001153138      1,077,101,397      UNC_CLOCK.SOCKET                 #     1.08 UNCORE_FREQ
>      1.001153138      1,012,773,595      duration_time
> ...
> ```

+linux-hwmon@vger.kernel.org as a heads up.

Thanks,
Ian

> Additional data on the hwmon events is in perf list:
> ```
> $ perf list
> ...
> hwmon:
> ...
>   temp_core_0 OR temp2
>        [Temperature in unit coretemp named Core 0. crit=100'C,max=100'C crit_alarm=0'C. Unit:
>         hwmon_coretemp]
> ...
> ```
>
> Ian Rogers (15):
>   perf list: Avoid potential out of bounds memory read
>   perf pmus: Fake PMU clean up
>   perf evsel: Add accessor for tool_event
>   perf pmu: To info add event_type_desc
>   perf pmu: Allow hardcoded terms to be applied to attributes
>   perf parse-events: Expose/rename config_term_name
>   perf tool_pmu: Factor tool events into their own PMU
>   perf tool_pmu: Rename enum perf_tool_event to tool_pmu_event
>   perf tool_pmu: Rename perf_tool_event__* to tool_pmu__*
>   perf tool_pmu: Move expr literals to tool_pmu
>   perf jevents: Add tool event json under a common architecture
>   perf tool_pmu: Switch to standard pmu functions and json descriptions
>   perf tests: Add tool PMU test
>   perf hwmon_pmu: Add a tool PMU exposing events from hwmon in sysfs
>   perf docs: Document tool and hwmon events
>
>  tools/perf/Documentation/perf-list.txt        |  15 +
>  tools/perf/arch/arm64/util/pmu.c              |   5 +-
>  tools/perf/arch/x86/util/intel-pt.c           |   3 +-
>  tools/perf/arch/x86/util/tsc.c                |  16 +-
>  tools/perf/builtin-list.c                     |  15 +-
>  tools/perf/builtin-stat.c                     |   7 +-
>  .../pmu-events/arch/common/common/tool.json   |  74 ++
>  tools/perf/pmu-events/empty-pmu-events.c      | 208 +++--
>  tools/perf/pmu-events/jevents.py              |  16 +-
>  tools/perf/tests/Build                        |   1 +
>  tools/perf/tests/builtin-test.c               |   1 +
>  tools/perf/tests/parse-events.c               |   4 +-
>  tools/perf/tests/pmu-events.c                 |  12 +-
>  tools/perf/tests/pmu.c                        |   3 +-
>  tools/perf/tests/tests.h                      |   1 +
>  tools/perf/tests/tool_pmu.c                   | 111 +++
>  tools/perf/util/Build                         |   2 +
>  tools/perf/util/evsel.c                       | 287 +-----
>  tools/perf/util/evsel.h                       |  23 +-
>  tools/perf/util/expr.c                        |  93 +-
>  tools/perf/util/hwmon_pmu.c                   | 879 ++++++++++++++++++
>  tools/perf/util/hwmon_pmu.h                   |  30 +
>  tools/perf/util/metricgroup.c                 |  45 +-
>  tools/perf/util/parse-events.c                |  92 +-
>  tools/perf/util/parse-events.h                |  13 +-
>  tools/perf/util/parse-events.l                |  11 -
>  tools/perf/util/parse-events.y                |  16 -
>  tools/perf/util/pmu.c                         | 108 ++-
>  tools/perf/util/pmu.h                         |  17 +-
>  tools/perf/util/pmus.c                        |  25 +-
>  tools/perf/util/pmus.h                        |   1 +
>  tools/perf/util/print-events.c                |  36 +-
>  tools/perf/util/print-events.h                |   1 -
>  tools/perf/util/stat-display.c                |  14 +-
>  tools/perf/util/stat-shadow.c                 |  24 +-
>  tools/perf/util/tool_pmu.c                    | 508 ++++++++++
>  tools/perf/util/tool_pmu.h                    |  56 ++
>  tools/perf/util/tsc.h                         |   2 +-
>  38 files changed, 2116 insertions(+), 659 deletions(-)
>  create mode 100644 tools/perf/pmu-events/arch/common/common/tool.json
>  create mode 100644 tools/perf/tests/tool_pmu.c
>  create mode 100644 tools/perf/util/hwmon_pmu.c
>  create mode 100644 tools/perf/util/hwmon_pmu.h
>  create mode 100644 tools/perf/util/tool_pmu.c
>  create mode 100644 tools/perf/util/tool_pmu.h
>
> --
> 2.46.0.469.g59c65b2a67-goog
>

Re: [PATCH v1 00/15] Tool and hwmon PMUs

Posted by Guenter Roeck 2 months, 3 weeks ago

On 9/9/24 19:21, Ian Rogers wrote:
> On Fri, Sep 6, 2024 at 10:08 PM Ian Rogers <irogers@google.com> wrote:
>>
>> Rather than have fake and tool PMUs being special flags in an evsel,
>> create special PMUs. This allows, for example, duration_time to also
>> be tool/duration_time/. Once adding events to the tools PMU is just
>> adding to an array, add events for nearly all the expr literals like
>> num_cpus_online. Rather than create custom logic for finding and
>> describing the tool events use json and add a notion of common json
>> for the tool events.
>>
>> Following the convention of the tool PMU, create a hwmon PMU that
>> exposes hwmon data for reading. For example, the following shows
>> reading the CPU temperature and 2 fan speeds alongside the uncore
>> frequency:
>> ```
>> $ perf stat -e temp_cpu,fan1,hwmon_thinkpad/fan2/,tool/num_cpus_online/ -M UNCORE_FREQ -I 1000
>>       1.001153138              52.00 'C   temp_cpu
>>       1.001153138              2,588 rpm  fan1
>>       1.001153138              2,482 rpm  hwmon_thinkpad/fan2/
>>       1.001153138                  8      tool/num_cpus_online/
>>       1.001153138      1,077,101,397      UNC_CLOCK.SOCKET                 #     1.08 UNCORE_FREQ
>>       1.001153138      1,012,773,595      duration_time
>> ...
>> ```
> 
> +linux-hwmon@vger.kernel.org as a heads up.
> 

No idea what you are doing, or why. I am not sure if I care, unless you
introduce dependencies on hwmon internals (or, in other words, define
undocumented APIs into hwmon). Which I'd argue would be a no-go.

Guenter